Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2488843003: Reland of Use mojo support for Blink devicechange event. (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use mojo support for Blink devicechange event. (patchset #1 id:1 of https://codereview.chromium.org/2483413002/ ) Reason for revert: Relanding since the relanding of MediaStreamTrack.getSources (the ermoval of which is interfering with perf tests) will have to be manual anyway. Original issue's description: > Revert of Use mojo support for Blink devicechange event. (patchset #3 id:120001 of https://codereview.chromium.org/2476153002/ ) > > Reason for revert: > Reverting due to this CL due to it blocking the revert of another CL that is interfering with perf tests. Will reland after that. > > See crbug.com/662414 > > Original issue's description: > > Use mojo support for Blink devicechange event. > > > > BUG=648183 > > > > Committed: https://crrev.com/6a0339c962198b75c333eb14bafa6374890d738a > > Cr-Commit-Position: refs/heads/master@{#430318} > > TBR=hbos@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=648183 > > Committed: https://crrev.com/d9a27e0a82856485f39a73863431211475bf8789 > Cr-Commit-Position: refs/heads/master@{#430899} TBR=hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648183 Committed: https://crrev.com/662a6038482e0b7bb1d3893491cdcbac33a807f2 Cr-Commit-Position: refs/heads/master@{#430901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -22 lines) Patch
M content/renderer/media/user_media_client_impl.h View 4 chunks +9 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 3 chunks +28 lines, -6 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 7 chunks +45 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Guido Urdaneta
Created Reland of Use mojo support for Blink devicechange event.
4 years, 1 month ago (2016-11-09 09:18:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488843003/1
4 years, 1 month ago (2016-11-09 09:19:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 09:20:10 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 09:22:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/662a6038482e0b7bb1d3893491cdcbac33a807f2
Cr-Commit-Position: refs/heads/master@{#430901}

Powered by Google App Engine
This is Rietveld 408576698