chrome/browser/ui/cocoa/l10n_util.mm - Issue 2488833002: [Mac] Reverse tabs in RTL mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/l10n_util.mm

Issue 2488833002: [Mac] Reverse tabs in RTL mode (Closed)

Patch Set: Update icon mask and add force RTL direction Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/l10n_util.h"	5 #import "chrome/browser/ui/cocoa/l10n_util.h"

6	6

7 #include "base/feature_list.h"

8 #include "base/i18n/rtl.h"	7 #include "base/i18n/rtl.h"

9 #include "base/strings/string_util.h"	8 #include "base/strings/string_util.h"

10 #include "base/strings/sys_string_conversions.h"	9 #include "base/strings/sys_string_conversions.h"

11 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTw eaker.h"	10 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTw eaker.h"

12	11

13 namespace cocoa_l10n_util {	12 namespace cocoa_l10n_util {

14	13

15 NSInteger CompareFrameY(id view1, id view2, void* context) {	14 NSInteger CompareFrameY(id view1, id view2, void* context) {

16 CGFloat y1 = NSMinY([view1 frame]);	15 CGFloat y1 = NSMinY([view1 frame]);

17 CGFloat y2 = NSMinY([view2 frame]);	16 CGFloat y2 = NSMinY([view2 frame]);

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86	85

87 const base::Feature kExperimentalMacRTL{"ExperimentalMacRTL",	86 const base::Feature kExperimentalMacRTL{"ExperimentalMacRTL",

88 base::FEATURE_DISABLED_BY_DEFAULT};	87 base::FEATURE_DISABLED_BY_DEFAULT};

89	88

90 bool ShouldDoExperimentalRTLLayout() {	89 bool ShouldDoExperimentalRTLLayout() {

91 return base::i18n::IsRTL() &&	90 return base::i18n::IsRTL() &&

92 base::FeatureList::IsEnabled(kExperimentalMacRTL);	91 base::FeatureList::IsEnabled(kExperimentalMacRTL);

93 }	92 }

94	93

95 } // namespace cocoa_l10n_util	94 } // namespace cocoa_l10n_util

OLD	NEW

« no previous file with comments | « chrome/browser/ui/cocoa/l10n_util.h ('k') | chrome/browser/ui/cocoa/tabs/tab_controller.h » ('j') | no next file with comments »