Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2488803002: Revert of Enable ALPC lockdown on >= win10 (Closed)

Created:
4 years, 1 month ago by Will Harris
Modified:
4 years, 1 month ago
Reviewers:
liamjm (20p)
CC:
chromium-reviews, jam, darin-cc_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable ALPC lockdown on >= win10 (patchset #2 id:20001 of https://codereview.chromium.org/2246543002/ ) Reason for revert: seems to be causing crashes with Avast! and issues with SharedMemory/HandleVerifier. Original issue's description: > Enable ALPC lockdown on >= win10 to further tighten up the sandbox on Windows. > > This is already enabled in sandbox tests, but this CL will enable it for all tests, and for all chrome renderers. > > BUG=464430 > > Committed: https://crrev.com/c9f56c97ccec49da955caf9b7e548f1bdd66144e > Cr-Commit-Position: refs/heads/master@{#428799} TBR=liamjm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=464430, 661315, 661194 Committed: https://crrev.com/316a0c0633b857b49e469037517c09d811dc4703 Cr-Commit-Position: refs/heads/master@{#430727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/common/sandbox_win.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Will Harris
Created Revert of Enable ALPC lockdown on >= win10
4 years, 1 month ago (2016-11-08 20:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488803002/1
4 years, 1 month ago (2016-11-08 20:38:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:56:19 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 22:01:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/316a0c0633b857b49e469037517c09d811dc4703
Cr-Commit-Position: refs/heads/master@{#430727}

Powered by Google App Engine
This is Rietveld 408576698