Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2488763002:
Use ICU's case mapping API for Greek uppercasing (Closed)
|
Created:
4 years, 1 month ago by jungshik at Google Modified:
4 years, 1 month ago CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse ICU's case mapping API for Greek uppercasing
Follow-up to ICU update to 58.1.
ICU's regular uppercasing API now supports Greek uppercasing so that
there's no more need to use transliterator.
As a result, Greek uppercasig should be a lot faster than before.
BUG=637001
TEST=wtf_unittests --gtest_filter=*UpperLoc*
Committed: https://crrev.com/0d2133839bd06c22c31bfc1695035a13811163ab
Cr-Commit-Position: refs/heads/master@{#432155}
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
wtf unittests may need to be updated.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use ICU's regular API for uppercasing for Greek Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=... ========== to ========== Use ICU's regular API for uppercasing for Greek Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ==========
Description was changed from ========== Use ICU's regular API for uppercasing for Greek Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ========== to ========== Use ICU's regular API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ==========
jshin@chromium.org changed reviewers: + esprehn@chromium.org
Elliott, can you take a look? Thanks
Description was changed from ========== Use ICU's regular API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ========== to ========== Use ICU's case mapping API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ==========
jshin@chromium.org changed reviewers: + thakis@chromium.org
Nico, can you take a look? Thanks
lgtm
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use ICU's case mapping API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ========== to ========== Use ICU's case mapping API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use ICU's case mapping API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* ========== to ========== Use ICU's case mapping API for Greek uppercasing Follow-up to ICU update to 58.1. ICU's regular uppercasing API now supports Greek uppercasing so that there's no more need to use transliterator. As a result, Greek uppercasig should be a lot faster than before. BUG=637001 TEST=wtf_unittests --gtest_filter=*UpperLoc* Committed: https://crrev.com/0d2133839bd06c22c31bfc1695035a13811163ab Cr-Commit-Position: refs/heads/master@{#432155} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0d2133839bd06c22c31bfc1695035a13811163ab Cr-Commit-Position: refs/heads/master@{#432155}
Message was sent while issue was closed.
Nice! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
