Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: ipc/ipc_channel_proxy.cc

Issue 2488753002: Ensure clean up functions of MessageFilter are paired with their initialization functions (Closed)
Patch Set: +comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_proxy.cc
diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc
index 79b0299657764270fa7accd0c447f6dfbdc72fe8..a1571a43c2db7bbcb57a67a4b29f872f8151ef1c 100644
--- a/ipc/ipc_channel_proxy.cc
+++ b/ipc/ipc_channel_proxy.cc
@@ -212,6 +212,11 @@ void ChannelProxy::Context::OnChannelClosed() {
return;
for (auto& filter : pending_filters_) {
+ // OnFilterAdded and OnChannelConnected have not been called on
+ // MessageFilters in |pending_filters_|. Call them here to match
+ // OnChannelClosing and OnFilterRemoved.
+ filter->OnFilterAdded(nullptr);
+ filter->OnChannelConnected(peer_pid_);
filter->OnChannelClosing();
filter->OnFilterRemoved();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698