Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: ipc/ipc_channel_proxy.cc

Issue 2488753002: Ensure clean up functions of MessageFilter are paired with their initialization functions (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_proxy.cc
diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc
index 1e8bec057be0410d0694cd7343048ae3b53136bf..ddbe8267a5835b7acecb2cf8dee53cca78b5a4a1 100644
--- a/ipc/ipc_channel_proxy.cc
+++ b/ipc/ipc_channel_proxy.cc
@@ -212,6 +212,8 @@ void ChannelProxy::Context::OnChannelClosed() {
return;
for (auto& filter : pending_filters_) {
+ filter->OnFilterAdded(nullptr);
Ken Rockot(use gerrit already) 2016/11/10 00:49:55 nit: I think it's worth adding a comment here to c
tzik 2016/11/10 06:17:41 Done.
+ filter->OnChannelConnected(peer_pid_);
filter->OnChannelClosing();
filter->OnFilterRemoved();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698