Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2488743005: Add the Tab.TimeToReactivation metric to TabUsageRecorder (Closed)

Created:
4 years, 1 month ago by Patrick Monette
Modified:
4 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the Tab.TimeToReactivation metric to TabUsageRecorder This will be used in the future to determine when a tab should decreases in priority. Also remove the tracking of bookmarked tabs since the metrics indicate that it has no effect on the reactivation rates. Committed: https://crrev.com/79cb75bf875669b99144ee0466fa4d6f4a393af4 Cr-Commit-Position: refs/heads/master@{#431625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M chrome/browser/metrics/tab_usage_recorder.cc View 5 chunks +23 lines, -21 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Patrick Monette
Hey Rob, PTAL!
4 years, 1 month ago (2016-11-09 23:12:55 UTC) #3
rkaplow
lgtm
4 years, 1 month ago (2016-11-10 23:00:41 UTC) #5
Patrick Monette
Thanks!
4 years, 1 month ago (2016-11-10 23:07:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488743005/1
4 years, 1 month ago (2016-11-10 23:08:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/162292)
4 years, 1 month ago (2016-11-10 23:27:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488743005/1
4 years, 1 month ago (2016-11-11 19:28:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 20:38:03 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:00:21 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79cb75bf875669b99144ee0466fa4d6f4a393af4
Cr-Commit-Position: refs/heads/master@{#431625}

Powered by Google App Engine
This is Rietveld 408576698