content/browser/site_per_process_browsertest.cc - Issue 2488743003: (Re-)introduce AncestorThrottle to handle 'X-Frame-Options'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2488743003: (Re-)introduce AncestorThrottle to handle 'X-Frame-Options'. (Closed)

Patch Set: Addressed comments (@clamy). Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/site_per_process_browsertest.cc

diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc

index 5e0a3e295f57422ac552dc5c5b2bfc1134d2f387..92434de1029f8934931a28c2287c27def65a77eb 100644

--- a/content/browser/site_per_process_browsertest.cc

+++ b/content/browser/site_per_process_browsertest.cc

@@ -6904,7 +6904,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,

// Ensure that we don't use the blocked URL as the blocked frame's last

// committed URL (see https://crbug.com/622385).

- EXPECT_NE(root->child_at(0)->current_frame_host()->GetLastCommittedURL(),

+ EXPECT_NE(root->child_at(0)->current_frame_host()->last_successful_url(),

blocked_urls[i]);

// The blocked frame should still fire a load event in its parent's process.