(Re-)introduce AncestorThrottle to handle 'X-Frame-Options'.

components/error_page/common/localized_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/error_page/common/localized_error.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 66 matching lines @@
 struct LocalizedErrorMap {
   int error_code;
   unsigned int heading_resource_id;
   // Detailed summary used when the error is in the main frame and shown on
   // mouse over when the error is in a frame.
   unsigned int summary_resource_id;
   int suggestions;  // Bitmap of SUGGEST_* values.
   int buttons; // Which buttons if any to show.
 };
 
+// clang-format off
 const LocalizedErrorMap net_error_options[] = {
   {net::ERR_TIMED_OUT,
    IDS_ERRORPAGES_HEADING_NOT_AVAILABLE,
    IDS_ERRORPAGES_SUMMARY_TIMED_OUT,
    SUGGEST_CHECK_CONNECTION | SUGGEST_FIREWALL_CONFIG | SUGGEST_PROXY_CONFIG |
        SUGGEST_DIAGNOSE_TOOL,
    SHOW_BUTTON_RELOAD,
   },
   {net::ERR_CONNECTION_TIMED_OUT,
    IDS_ERRORPAGES_HEADING_NOT_AVAILABLE,
@@ skipping 209 matching lines @@
    IDS_ERRORPAGES_SUMMARY_SSL_VERSION_OR_CIPHER_MISMATCH,
    SUGGEST_UNSUPPORTED_CIPHER,
    SHOW_NO_BUTTONS,
   },
   {net::ERR_SSL_SERVER_CERT_BAD_FORMAT,
    IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
    IDS_ERRORPAGES_SUMMARY_SSL_SECURITY_ERROR,
    SUGGEST_NONE,
    SHOW_NO_BUTTONS,
   },
+  {net::ERR_BLOCKED_BY_RESPONSE,

[clamy, 2016/12/09 17:14:01]

Does this mean net::ERR_BLOCKED_BY_RESPONSE will display an error page? If so,
is that what we want or do we want to display a blank frame?

[arthursonzogni, 2016/12/13 15:32:13]

Yes, the intent is to display error pages.
The thing is that after in RenderFrameImpl::LoadNavigationErrorPage, the
net::ERR_BLOCKED_BY_RESPONSE error page is transformed into a blank page because
there is a problem for the moment with how error pages are handled in Chrome.
The URL of the page that fails to load is committed in the browser, which causes
problems.

It would be nice if we could display an error page. That's what we want in the
future. Currently a blank page is displayed. That's the current chrome behavior
and this patch doesn't change this.

+   IDS_ERRORPAGES_HEADING_BLOCKED,
+   IDS_ERRORPAGES_SUMMARY_CONNECTION_REFUSED,
+   SUGGEST_NONE,
+   SHOW_NO_BUTTONS
+  },
 };
+// clang-format on
 
 // Special error page to be used in the case of navigating back to a page
 // generated by a POST.  LocalizedError::HasStrings expects this net error code
 // to also appear in the array above.
 const LocalizedErrorMap repost_error = {
   net::ERR_CACHE_MISS,
   IDS_HTTP_POST_WARNING_TITLE,
   IDS_ERRORPAGES_HTTP_POST_WARNING,
   SUGGEST_REPOST_RELOAD,
   SHOW_NO_BUTTONS,
@@ skipping 725 matching lines @@
 
 bool LocalizedError::HasStrings(const std::string& error_domain,
                                 int error_code) {
   // Whether or not the there are strings for an error does not depend on
   // whether or not the page was be generated by a POST, so just claim it was
   // not.
   return LookupErrorMap(error_domain, error_code, /*is_post=*/false) != nullptr;
 }
 
 }  // namespace error_page