Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2488743002: Remove legal messages from save card bubble before offering local save. (Closed)

Created:
4 years, 1 month ago by Justin Donnelly
Modified:
4 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, Jared Saul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legal messages from save card bubble before offering local save. Before this change, if upload is offered and then local save is offered, the legal messages associated with the upload are still present and incorrectly shown to the user for the local save. BUG=662169 Committed: https://crrev.com/32f5238cedacdaacd30b01617814494f3a461d75 Cr-Commit-Position: refs/heads/master@{#430669}

Patch Set 1 #

Patch Set 2 : Fix test crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Justin Donnelly
4 years, 1 month ago (2016-11-08 16:59:03 UTC) #9
Evan Stade
lgtm
4 years, 1 month ago (2016-11-08 17:54:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488743002/40001
4 years, 1 month ago (2016-11-08 18:29:01 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-08 18:44:02 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 19:08:37 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32f5238cedacdaacd30b01617814494f3a461d75
Cr-Commit-Position: refs/heads/master@{#430669}

Powered by Google App Engine
This is Rietveld 408576698