Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2488703002: [Interpreter] Switch back to optimizing after 2 ticks for Ignition code. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
mvstanton, mythria
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Switch back to optimizing after 2 ticks for Ignition code. It looks like waiting for 4 ticks before optimizing from interpreted code is hurting performance in sunspider after turning on Ignition for all TurboFan code. Set it back to 2 ticks. BUG=chromium:661556 Committed: https://crrev.com/cf5b0c590ced1dac3e8ead4631c507a48ab91f25 Cr-Commit-Position: refs/heads/master@{#40845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/runtime-profiler.cc View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
rmcilroy
Mythri, PTAL, thanks.
4 years, 1 month ago (2016-11-08 14:30:57 UTC) #4
mythria
lgtm.
4 years, 1 month ago (2016-11-08 14:56:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488703002/1
4 years, 1 month ago (2016-11-08 16:35:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 16:37:46 UTC) #10
mvstanton
Sigh, the world of heuristics. Thx for looking at that, Ross!
4 years, 1 month ago (2016-11-08 21:24:12 UTC) #12
rmcilroy
On 2016/11/08 21:24:12, mvstanton wrote: > Sigh, the world of heuristics. Thx for looking at ...
4 years, 1 month ago (2016-11-08 21:38:03 UTC) #13
mvstanton
No biggie, sounds good.
4 years, 1 month ago (2016-11-08 21:44:00 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf5b0c590ced1dac3e8ead4631c507a48ab91f25
Cr-Commit-Position: refs/heads/master@{#40845}

Powered by Google App Engine
This is Rietveld 408576698