Issue 248863002: MacViews: Introduce native_cursor.h to provide cursor "literals"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248863002: MacViews: Introduce native_cursor.h to provide cursor "literals" (Closed)

Created:
6 years, 8 months ago by tapted

Modified:
6 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

MacViews: Introduce native_cursor.h to provide cursor "literals" The ui:: cursors constants like ui::kCursorIBeam are gfx::NativeCursors on aura, but not other platforms. This change introduces ui/views/native_cursor.h, which provides a set of functions giving gfx::NativeCursor constants in a platform-independent way. BUG=366007 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266269

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -6 lines)			Patch
M	ui/views/controls/link.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/views/controls/resize_area.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ui/views/controls/single_split_view.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/views/controls/table/table_header.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/views/controls/textfield/textfield.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
A	ui/views/native_cursor.h	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	ui/views/native_cursor_aura.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	ui/views/native_cursor_mac.mm	View	1 chunk	+39 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/248863002/1

6 years, 8 months ago (2014-04-25 02:09:17 UTC) #4

Message was sent while issue was closed.

Change committed as 266269

Expand Messages | Collapse Messages