Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2488623002: [turbofan] Introduce TypedObjectState common operator. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Tobias Tebbi, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce TypedObjectState common operator. This adds a new TypedObjectState operator, which is a version of ObjectState that carries along MachineTypes for the inputs, so we can tell the deoptimizer how to interpret the inputs, instead of having to force everything to Tagged. Drive-by-fix: Remove the unused id parameter from ObjectState. R=tebbi@chromium.org BUG=v8:5609 Committed: https://crrev.com/a5d251defebb69c4a39634fc8de8a6b074c3daf3 Cr-Commit-Position: refs/heads/master@{#40832}

Patch Set 1 #

Patch Set 2 : Make MSVC happy. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -21 lines) Patch
M src/compiler/common-operator.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +22 lines, -8 lines 2 comments Download
M src/compiler/escape-analysis.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 4 chunks +10 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +32 lines, -1 line 0 comments Download
M src/compiler/state-values-utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-08 08:06:31 UTC) #1
Benedikt Meurer
Hey Tobias, Here's the CL we talked about offline; porting the machinery from (Typed)StateValues to ...
4 years, 1 month ago (2016-11-08 08:07:26 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-08 10:53:08 UTC) #12
Tobias Tebbi
lgtm https://codereview.chromium.org/2488623002/diff/20001/src/compiler/common-operator.cc File src/compiler/common-operator.cc (right): https://codereview.chromium.org/2488623002/diff/20001/src/compiler/common-operator.cc#newcode1027 src/compiler/common-operator.cc:1027: pointer_slots); // parameter Why put pointer_slots in this ...
4 years, 1 month ago (2016-11-08 13:41:40 UTC) #13
Benedikt Meurer
https://codereview.chromium.org/2488623002/diff/20001/src/compiler/common-operator.cc File src/compiler/common-operator.cc (right): https://codereview.chromium.org/2488623002/diff/20001/src/compiler/common-operator.cc#newcode1027 src/compiler/common-operator.cc:1027: pointer_slots); // parameter We need to distinguish the operators ...
4 years, 1 month ago (2016-11-08 13:42:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488623002/20001
4 years, 1 month ago (2016-11-08 13:43:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 13:45:02 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:04 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5d251defebb69c4a39634fc8de8a6b074c3daf3
Cr-Commit-Position: refs/heads/master@{#40832}

Powered by Google App Engine
This is Rietveld 408576698