Support dart2js in pub serve.

sdk/lib/_internal/pub/test/serve/utils.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS d.file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub_tests;
 
 import 'dart:async';
 
 import 'package:http/http.dart' as http;
 import 'package:scheduled_test/scheduled_process.dart';
@@ skipping 103 matching lines @@
   assert(match != null);
   _port = int.parse(match[1]);
 }
 
 void endPubServe() {
   _pubServer.kill();
 }
 
 /// Schedules an HTTP request to the running pub server with [urlPath] and
 /// verifies that it responds with [expected].
-void requestShouldSucceed(String urlPath, String expected) {
+void requestShouldSucceed(String urlPath, Pattern expected) {
+  // RegExps are matched, everything else must be equal. Note that we can't use

[nweiz, 2013/09/27 22:21:17]

At this point, it's probably cleaner to make [expected] be a Matcher (although
untyped as matcher parameters always are). In practice you're usually just
trying to do [contains] anyway.

[Bob Nystrom, 2013/09/28 00:56:11]

Most of the tests are testing for exact quality, and I don't want to add
equals() to every call to this, so I think this leads to the simplest code at
the callsite.

[nweiz, 2013/09/30 17:33:34]

Passing in a string will implicitly call [equals]; I'd be fine with that here.
As it stands the call-site for non-equality checks is much messier than it would
be otherwise.

[Bob Nystrom, 2013/10/01 19:08:55]

OK, done. I didn't do that before because I thought you weren't keen on relying
on the implicit equals() of non-Matcher arguments. Agreed that using contains()
looks better than a RegExp.

+  // matches() for a String because we want a String to mean "is exactly that"
+  // where matches() implicitly converts it to a RegExp.
+  var expectation;
+  if (expected is RegExp) {
+    expectation = matches(expected);
+  } else {
+    expectation = equals(expected);
+  }
+
   schedule(() {
     return http.get("http://127.0.0.1:$_port/$urlPath").then((response) {
-      expect(response.body, equals(expected));
+      expect(response.body, expectation);
     });
   }, "request $urlPath");
 }
 
 /// Schedules an HTTP request to the running pub server with [urlPath] and
 /// verifies that it responds with a 404.
 void requestShould404(String urlPath) {
   schedule(() {
     return http.get("http://127.0.0.1:$_port/$urlPath").then((response) {
       expect(response.statusCode, equals(404));
@@ skipping 21 matching lines @@
     return _pubServer.nextLine().then((line) {
       if (line.contains("successfully")) return;
 
       // This line wasn't it, so ignore it and keep trying.
       return nextLine();
     });
   }
 
   schedule(nextLine);
 }