Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h

Issue 2488573003: Expose signing key from cloud policy stores (Closed)
Patch Set: Some renamings according to feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
index 6aedbf191afa180010977c7dc178f44a715d19d2..3727eba8f3f9a5ad3dc7b4deda8b3982dd8e7d14 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
@@ -132,11 +132,16 @@ class UserCloudPolicyStoreChromeOS : public UserCloudPolicyStoreBase {
// the number of pre-M20 clients drops back to zero.
base::FilePath legacy_cache_dir_;
std::unique_ptr<LegacyPolicyCacheLoader> legacy_loader_;
- bool legacy_caches_loaded_;
-
- bool policy_key_loaded_;
- base::FilePath policy_key_path_;
- std::string policy_key_;
+ bool is_legacy_caches_load_performed_ = false;
Thiemo Nagel 2016/11/22 11:57:15 I guess this will go away after rebase.
emaxx 2016/11/22 16:16:51 Glad to hear that! :)
+
+ // The current key used to verify signatures of policy. This value is
Thiemo Nagel 2016/11/22 11:57:15 Nit: Please wrap at 80 characters.
emaxx 2016/11/22 16:16:51 Done.
+ // loaded from the key cache file (which is owned and kept up to date by the
+ // Chrome OS session manager). This is, generally, different from
+ // |policy_signature_public_key_|, which always corresponds to the currently
+ // effective policy.
+ std::string cached_policy_key_;
+ bool is_cached_policy_key_loaded_ = false;
Thiemo Nagel 2016/11/22 11:57:15 Nit: Imho the "is_" part of the name redundant and
emaxx 2016/11/22 16:16:51 Done.
+ base::FilePath cached_policy_key_path_;
base::WeakPtrFactory<UserCloudPolicyStoreChromeOS> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698