Expose signing key from cloud policy stores

chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h

Index: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
index 6aedbf191afa180010977c7dc178f44a715d19d2..608c9d99d7baf13b891e9c6803bd8d539eabe82e 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
@@ -132,11 +132,13 @@ class UserCloudPolicyStoreChromeOS : public UserCloudPolicyStoreBase {
   // the number of pre-M20 clients drops back to zero.
   base::FilePath legacy_cache_dir_;
   std::unique_ptr<LegacyPolicyCacheLoader> legacy_loader_;
-  bool legacy_caches_loaded_;
+  bool is_legacy_caches_load_performed_ = false;
 
-  bool policy_key_loaded_;
+  const std::string owning_domain_;

[Thiemo Nagel, 2016/11/21 17:45:34]

Afaics, |owning_domain_| is only used in one place.  Maybe it would be better to
remove it again?

[emaxx, 2016/11/21 20:04:58]

That's true, rebasing eliminated all other usages.
Done.

+
+  bool is_policy_key_loaded_ = false;
   base::FilePath policy_key_path_;
-  std::string policy_key_;
+  std::string loaded_policy_key_;

[Thiemo Nagel, 2016/11/21 17:45:34]

I think |loaded_policy_key_| deserves a comment.

Maybe you could also come up with a better name?  Maybe |cached_policy_key_| or
something else?

Or maybe it would work to rename |public_key_| to |policy_signing_key_| or
|policy_signature_key_| to differentiate it more?

[emaxx, 2016/11/21 20:04:58]

Done. Added comment, renamed to "cached_policy_key_".

 
   base::WeakPtrFactory<UserCloudPolicyStoreChromeOS> weak_factory_;