Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/WebKit/public/platform/modules/installedapp/WebRelatedAppsFetcher.h

Issue 2488573002: Refactor getInstalledRelatedApps code and add manifest logic and tests. (Closed)
Patch Set: Use SecurityOrigin, not WebSecurityOrigin. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/installedapp/WebRelatedAppsFetcher.h
diff --git a/third_party/WebKit/public/platform/modules/installedapp/WebInstalledAppClient.h b/third_party/WebKit/public/platform/modules/installedapp/WebRelatedAppsFetcher.h
similarity index 58%
rename from third_party/WebKit/public/platform/modules/installedapp/WebInstalledAppClient.h
rename to third_party/WebKit/public/platform/modules/installedapp/WebRelatedAppsFetcher.h
index ad8e0ffd0f497dbd7d458ab8ba0f3611ab576848..94c93d838cc7366dcb8072361544da6f75304b20 100644
--- a/third_party/WebKit/public/platform/modules/installedapp/WebInstalledAppClient.h
+++ b/third_party/WebKit/public/platform/modules/installedapp/WebRelatedAppsFetcher.h
@@ -1,30 +1,31 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
+// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef WebInstalledAppClient_h
-#define WebInstalledAppClient_h
+#ifndef WebRelatedAppsFetcher_h
+#define WebRelatedAppsFetcher_h
#include "public/platform/WebCallbacks.h"
#include "public/platform/WebSecurityOrigin.h"
#include "public/platform/WebVector.h"
#include "public/platform/modules/installedapp/WebRelatedApplication.h"
+#include <memory>
+
namespace blink {
using AppInstalledCallbacks =
WebCallbacks<const WebVector<WebRelatedApplication>&, void>;
-class WebInstalledAppClient {
+class WebRelatedAppsFetcher {
public:
- virtual ~WebInstalledAppClient() {}
+ virtual ~WebRelatedAppsFetcher() {}
- // Takes ownership of the AppInstalledCallbacks.
- virtual void getInstalledRelatedApps(
- const WebSecurityOrigin&,
+ // Gets the list of related applications from the web frame's manifest.
+ virtual void getManifestRelatedApplications(
std::unique_ptr<AppInstalledCallbacks>) = 0;
};
} // namespace blink
-#endif // WebInstalledAppClient_h
+#endif // WebRelatedAppsFetcher_h

Powered by Google App Engine
This is Rietveld 408576698