third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp - Issue 2488573002: Refactor getInstalledRelatedApps code and add manifest logic and tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

Issue 2488573002: Refactor getInstalledRelatedApps code and add manifest logic and tests. (Closed)

Patch Set: Use SecurityOrigin, not WebSecurityOrigin. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

diff --git a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

index 06b5b603f944ba8230e372409352970d35fbd29f..e3cb67888b8a1c7ab124fc0d31ae4a46db813539 100644

--- a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

+++ b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

@@ -16,7 +16,6 @@

#include "core/frame/Navigator.h"

#include "modules/installedapp/InstalledAppController.h"

#include "modules/installedapp/RelatedApplication.h"

-#include "public/platform/modules/installedapp/WebInstalledAppClient.h"

#include "public/platform/modules/installedapp/WebRelatedApplication.h"

#include "wtf/PtrUtil.h"

@@ -79,9 +78,8 @@ ScriptPromise NavigatorInstalledApp::getInstalledRelatedApps(

return promise;

}

- appController->getInstalledApps(

- WebSecurityOrigin(

- scriptState->getExecutionContext()->getSecurityOrigin()),

+ appController->getInstalledRelatedApps(

+ scriptState->getExecutionContext()->getSecurityOrigin(),

WTF::wrapUnique(

new CallbackPromiseAdapter<RelatedAppArray, void>(resolver)));

return promise;