Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2488553004: Revert of [ios] Refactored back-forward navigation in CRWSessionController. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Refactored back-forward navigation in CRWSessionController. (patchset #5 id:80001 of https://codereview.chromium.org/2470913007/ ) Reason for revert: GoDelta test fails on 32-bit platform Original issue's description: > [ios] Refactored back-forward navigation in CRWSessionController. > > Notable changes: > - Added public -[CRWSessionController indexOfEntryForDelta:] which will > be used in future BF navigation refactorings (crbug.com/661858). This > API will allow to tell the future navigation index w/o making an > actual navigation and pass that future entry to > |isSameDocumentNavigationBetweenEntry:andEntry:| call. > - Made goDelta: no-op if delta is out of bounds. This make > CRWSessionController implementation better conform to w3 spec: > https://www.w3.org/TR/html5/browsers.html#the-history-interface > - Added public canGoDelta: API and use it in canGoBack/canGoForward. > - goBack and goForward now implemented by calling goDelta:-1 and > goDelta:1. This way the implementation is more efficient (no extra > calls of |discardNonCommittedEntries| and |discardTransientEntry|) > and cleaner. > - Do not change previousNavigationIndex if navigation did not happen. > - Added more unit tests. > > Further cleanups (like reusing indexOfEntryForDelta: and > isRedirectTransitionForEntryAtIndex:) will be done in separate CLs. > > BUG=661820 > > Committed: https://crrev.com/44dc0832429cf6754c254739d4939382e5ee3b71 > Cr-Commit-Position: refs/heads/master@{#430435} TBR=kkhorimoto@chromium.org,rohitrao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661820 Committed: https://crrev.com/300b8d4cd1c946373960c9e0f903b704bed36d41 Cr-Commit-Position: refs/heads/master@{#430506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -314 lines) Patch
M ios/web/navigation/crw_session_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 4 chunks +82 lines, -82 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 14 chunks +3 lines, -226 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Eugene But (OOO till 7-30)
Created Revert of [ios] Refactored back-forward navigation in CRWSessionController.
4 years, 1 month ago (2016-11-08 03:40:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488553004/1
4 years, 1 month ago (2016-11-08 03:40:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 03:42:08 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:45:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/300b8d4cd1c946373960c9e0f903b704bed36d41
Cr-Commit-Position: refs/heads/master@{#430506}

Powered by Google App Engine
This is Rietveld 408576698