Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2488543002: fix #27775, enum declaration where "name" is a property (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -28 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +12 lines, -17 lines 0 comments Download
A + pkg/dev_compiler/test/codegen/language/enum_value_name_test.dart View 1 chunk +5 lines, -9 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 1 month ago (2016-11-08 01:53:59 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-08 18:16:51 UTC) #3
Jennifer Messerly
4 years, 1 month ago (2016-11-08 18:18:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3995146b55d4b7f358a80e7966f94f42fd2f067c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698