Chromium Code Reviews
DescriptionRevert of Enable SequencedWorkerPool to TaskScheduler redirection in testing config. (patchset #2 id:20001 of https://codereview.chromium.org/2446603002/ )
Reason for revert:
This caused a 1.1% regression in system_health.memory_mobile. https://crbug.com/661520
Original issue's description:
> Enable SequencedWorkerPool to TaskScheduler redirection in testing config.
>
> With this CL, redirection of SequencedWorkerPools to TaskScheduler will
> be tested on bots.
>
> Before a similar CL https://codereview.chromium.org/2353973002/ landed,
> SequencedWorkerPool tasks didn't generate tracing events. With
> redirection to TaskScheduler enabled, the same tasks started to generate
> tracing events. That affected the battor.power_cases/cpu_time_percentage_max
> graph https://crbug.com/656629 and the CL was reverted. Now that
> SequencedWorkerPool tasks generate tracing events
> https://codereview.chromium.org/2429863002/, enabling redirection
> to TaskScheduler shouldn't affect any performance graph. Note that the
> battor.power_cases/cpu_time_percentage_max graph didn't go up when tracing
> was enabled in SequencedWorkerPools because of
> https://codereview.chromium.org/2420133002/ which reduced the CPU
> consumption of a task running in the blocking pool.
>
> BUG=622400
>
> Committed: https://crrev.com/9b3162c323b6529cbba17fb419129fea26b75257
> Cr-Commit-Position: refs/heads/master@{#427375}
TBR=gab@chromium.org,rkaplow@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622400, 661520
Committed: https://crrev.com/5a6dfbbcae66fe80acefd8e1f0d812cdc4551bb6
Cr-Commit-Position: refs/heads/master@{#430616}
Patch Set 1 #
Messages
Total messages: 10 (6 generated)
|
|||||||||||||||||||