Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2488513003: Revert of Enable SequencedWorkerPool to TaskScheduler redirection in testing config. (Closed)

Created:
4 years, 1 month ago by fdoray
Modified:
4 years, 1 month ago
Reviewers:
gab, rkaplow
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable SequencedWorkerPool to TaskScheduler redirection in testing config. (patchset #2 id:20001 of https://codereview.chromium.org/2446603002/ ) Reason for revert: This caused a 1.1% regression in system_health.memory_mobile. https://crbug.com/661520 Original issue's description: > Enable SequencedWorkerPool to TaskScheduler redirection in testing config. > > With this CL, redirection of SequencedWorkerPools to TaskScheduler will > be tested on bots. > > Before a similar CL https://codereview.chromium.org/2353973002/ landed, > SequencedWorkerPool tasks didn't generate tracing events. With > redirection to TaskScheduler enabled, the same tasks started to generate > tracing events. That affected the battor.power_cases/cpu_time_percentage_max > graph https://crbug.com/656629 and the CL was reverted. Now that > SequencedWorkerPool tasks generate tracing events > https://codereview.chromium.org/2429863002/, enabling redirection > to TaskScheduler shouldn't affect any performance graph. Note that the > battor.power_cases/cpu_time_percentage_max graph didn't go up when tracing > was enabled in SequencedWorkerPools because of > https://codereview.chromium.org/2420133002/ which reduced the CPU > consumption of a task running in the blocking pool. > > BUG=622400 > > Committed: https://crrev.com/9b3162c323b6529cbba17fb419129fea26b75257 > Cr-Commit-Position: refs/heads/master@{#427375} TBR=gab@chromium.org,rkaplow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622400, 661520 Committed: https://crrev.com/5a6dfbbcae66fe80acefd8e1f0d812cdc4551bb6 Cr-Commit-Position: refs/heads/master@{#430616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
fdoray
Created Revert of Enable SequencedWorkerPool to TaskScheduler redirection in testing config.
4 years, 1 month ago (2016-11-08 13:54:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488513003/1
4 years, 1 month ago (2016-11-08 13:54:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 15:28:14 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 15:34:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a6dfbbcae66fe80acefd8e1f0d812cdc4551bb6
Cr-Commit-Position: refs/heads/master@{#430616}

Powered by Google App Engine
This is Rietveld 408576698