Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2488463004: Move sub-pages of "Layout Tests" from Google Sites to Markdown. (Closed)

Created:
4 years, 1 month ago by pwnall
Modified:
4 years, 1 month ago
Reviewers:
jsbell, qyearsley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move sub-pages of "Layout Tests" from Google Sites to Markdown. The page on LayoutTests in dev.chromium.org [1] has already been moved to Markdown. This CL moves its sub-pages to Markdown as well. [1] https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests BUG= Committed: https://crrev.com/d8a250726ee1183678f8bb145b2bf5459f712394 Cr-Commit-Position: refs/heads/master@{#430981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -7 lines) Patch
A docs/testing/identifying_tests_that_depend_on_order.md View 1 chunk +80 lines, -0 lines 0 comments Download
A docs/testing/layout_test_expectations.md View 1 chunk +298 lines, -0 lines 0 comments Download
M docs/testing/layout_tests.md View 3 chunks +8 lines, -7 lines 0 comments Download
A docs/testing/layout_tests_in_content_shell.md View 1 chunk +69 lines, -0 lines 0 comments Download
A docs/testing/using_breakpad_with_content_shell.md View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
pwnall
PTAL? I figured I should move these pages over too, since I moved their master. ...
4 years, 1 month ago (2016-11-09 00:46:51 UTC) #4
jsbell
lgtm
4 years, 1 month ago (2016-11-09 17:29:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488463004/1
4 years, 1 month ago (2016-11-09 18:19:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 18:24:34 UTC) #10
pwnall
On 2016/11/09 17:29:43, jsbell wrote: > lgtm Thank you for the quick turnaround!
4 years, 1 month ago (2016-11-09 18:36:51 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8a250726ee1183678f8bb145b2bf5459f712394 Cr-Commit-Position: refs/heads/master@{#430981}
4 years, 1 month ago (2016-11-09 18:46:56 UTC) #13
qyearsley
4 years, 1 month ago (2016-11-14 18:56:30 UTC) #14
Message was sent while issue was closed.
On 2016/11/09 at 18:46:56, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/d8a250726ee1183678f8bb145b2bf5459f712394
> Cr-Commit-Position: refs/heads/master@{#430981}

LGTM too, thanks for moving the documentation :-)

Powered by Google App Engine
This is Rietveld 408576698