Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2488443002: [Extensions] Convert some callers of ScriptContext::CallFunction (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some callers of ScriptContext::CallFunction ScriptContext::CallFunction is deprecated (see bug for more info). Convert some callers to use ScriptContext::SafeCallFunction. BUG=629431 Committed: https://crrev.com/82f54699b5a977642331f5f66d07c91365dbe706 Cr-Commit-Position: refs/heads/master@{#430460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Devlin
4 years, 1 month ago (2016-11-08 00:53:04 UTC) #6
lazyboy
nit in CL desc: s/CallFunctionSafe/SafeCallFunction. lgtm.
4 years, 1 month ago (2016-11-08 01:08:44 UTC) #7
Devlin
On 2016/11/08 01:08:44, lazyboy wrote: > nit in CL desc: s/CallFunctionSafe/SafeCallFunction. Done.
4 years, 1 month ago (2016-11-08 01:10:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488443002/1
4 years, 1 month ago (2016-11-08 01:11:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 01:19:13 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 01:33:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82f54699b5a977642331f5f66d07c91365dbe706
Cr-Commit-Position: refs/heads/master@{#430460}

Powered by Google App Engine
This is Rietveld 408576698