Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3141)

Unified Diff: base/strings/string_util_unittest.cc

Issue 248843004: Remove WCHAR_T_IS_UNSIGNED definition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove WCHAR_T_IS_UNSIGNED Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/build_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/strings/string_util_unittest.cc
diff --git a/base/strings/string_util_unittest.cc b/base/strings/string_util_unittest.cc
index e447cdc39024cce1eebc3e9932a3d61602a54d3b..4ea9069a255a82d76c8294245cd1139f4959ee61 100644
--- a/base/strings/string_util_unittest.cc
+++ b/base/strings/string_util_unittest.cc
@@ -1011,13 +1011,8 @@ TEST(StringUtilTest, LcpyTest) {
EXPECT_EQ(1, dst[0]);
EXPECT_EQ(2, dst[1]);
EXPECT_EQ(7U, base::wcslcpy(wdst, L"abcdefg", 0));
-#if defined(WCHAR_T_IS_UNSIGNED)
- EXPECT_EQ(1U, wdst[0]);
- EXPECT_EQ(2U, wdst[1]);
-#else
- EXPECT_EQ(1, wdst[0]);
- EXPECT_EQ(2, wdst[1]);
-#endif
+ EXPECT_EQ(static_cast<wchar_t>(1), wdst[0]);
+ EXPECT_EQ(static_cast<wchar_t>(2), wdst[1]);
}
// Test the case were we _just_ competely fit including the null.
« no previous file with comments | « no previous file | build/build_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698