Mus: ImageTransportSurface should not depend on GpuChannelManager

Mus: ImageTransportSurface should not depend on GpuChannelManager

ImageTransportSurface took in a GpuChannelManager to use on Windows
to create a ChildWindowSurface. ChildWindowSurface informs the
GpuChannelManager (and subsequently the GpuChannelManagerDelegate) of
the newly created child window. This CL instead plumbs that
notification through ImageTransportSurfaceDelegate eliminating the
dependency on GpuChannelManager.

We can now use ImageTransportSurface in InProcessCommandBuffer without
depending on GpuChannelManager.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c0409e0a00097fbe961e3c22e36c5f1a0f211cfc
Cr-Commit-Position: refs/heads/master@{#431524}

[Fady Samuel, 2016-11-10 23:11:25]

Description was changed from

==========
Mus: ImageTransportSurface should not depend on GpuChannelManager

ImageTransportSurface took in a GpuChannelManager to use on Windows
to create a ChildWindowSurface. ChildWindowSurface informs the
GpuChannelManager (and subsequently the GpuChannelManagerDelegate) of
the newly created child window. This CL instead plumbs that
notification through ImageTransportSurfaceDelegate eliminating the
dependency on GpuChannelManager.

We can now use ImageTransportSurface in InProcessCommandBuffer without
depending on GpuChannelManager.

BUG=661278
==========

to

==========
Mus: ImageTransportSurface should not depend on GpuChannelManager

ImageTransportSurface took in a GpuChannelManager to use on Windows
to create a ChildWindowSurface. ChildWindowSurface informs the
GpuChannelManager (and subsequently the GpuChannelManagerDelegate) of
the newly created child window. This CL instead plumbs that
notification through ImageTransportSurfaceDelegate eliminating the
dependency on GpuChannelManager.

We can now use ImageTransportSurface in InProcessCommandBuffer without
depending on GpuChannelManager.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-11-10 23:11:33]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-11-10 23:11:48]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org, vmiura@chromium.org

[Fady Samuel, 2016-11-10 23:11:48]

PTAL

[commit-bot: I haz the power, 2016-11-10 23:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:30:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-11-10 23:31:27]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:32:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:46:06]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[piman, 2016-11-11 05:04:37]

lgtm % compile issues (missing includes?)

[Fady Samuel, 2016-11-11 05:49:29]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-11 05:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2488413003/#ps20001
(title: "Fixed ChildWindowSurface")

[commit-bot: I haz the power, 2016-11-11 05:49:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 06:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 06:20:29]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2016-11-11 06:51:21]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-11 06:51:21]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2488413003/#ps40001
(title: "Added missing includes")

[commit-bot: I haz the power, 2016-11-11 06:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-11 07:11:14]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-11 07:11:15]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2488413003/#ps60001
(title: "Adding missing include and fix variable name")

[commit-bot: I haz the power, 2016-11-11 07:11:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-11 07:28:30]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-11 07:28:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2488413003/#ps80001
(title: "Fix windows compile issue")

[commit-bot: I haz the power, 2016-11-11 07:28:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 08:24:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-11 08:27:01]

Description was changed from

==========
Mus: ImageTransportSurface should not depend on GpuChannelManager

ImageTransportSurface took in a GpuChannelManager to use on Windows
to create a ChildWindowSurface. ChildWindowSurface informs the
GpuChannelManager (and subsequently the GpuChannelManagerDelegate) of
the newly created child window. This CL instead plumbs that
notification through ImageTransportSurfaceDelegate eliminating the
dependency on GpuChannelManager.

We can now use ImageTransportSurface in InProcessCommandBuffer without
depending on GpuChannelManager.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mus: ImageTransportSurface should not depend on GpuChannelManager

ImageTransportSurface took in a GpuChannelManager to use on Windows
to create a ChildWindowSurface. ChildWindowSurface informs the
GpuChannelManager (and subsequently the GpuChannelManagerDelegate) of
the newly created child window. This CL instead plumbs that
notification through ImageTransportSurfaceDelegate eliminating the
dependency on GpuChannelManager.

We can now use ImageTransportSurface in InProcessCommandBuffer without
depending on GpuChannelManager.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c0409e0a00097fbe961e3c22e36c5f1a0f211cfc
Cr-Commit-Position: refs/heads/master@{#431524}
==========

[commit-bot: I haz the power, 2016-11-11 08:27:02]

Patchset 5 (id:??) landed as
https://crrev.com/c0409e0a00097fbe961e3c22e36c5f1a0f211cfc
Cr-Commit-Position: refs/heads/master@{#431524}