Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: ui/views/focus/focus_manager_unittest.cc

Issue 2488393003: Changes views_aura_mus_unittests to create DesktopNativeWidgetAura (Closed)
Patch Set: git add Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/focus/focus_manager_unittest.cc
diff --git a/ui/views/focus/focus_manager_unittest.cc b/ui/views/focus/focus_manager_unittest.cc
index a655eafcc45e0c3d37abf43989a3f78704fc6db0..b2ed4dc2af1c7a200a63ebb347f267fca09b4cc2 100644
--- a/ui/views/focus/focus_manager_unittest.cc
+++ b/ui/views/focus/focus_manager_unittest.cc
@@ -122,6 +122,12 @@ TEST_F(FocusManagerTest, FocusChangeListener) {
}
TEST_F(FocusManagerTest, WidgetFocusChangeListener) {
+ // TODO: this test ends up calling focus on the aura::Window associated with
+ // the Widget and expecting that to change acivation. This should work for
msw 2016/11/11 00:29:24 nit: activation
sky 2016/11/11 01:09:13 Done.
+ // aura-mus-client as well. http://crbug.com/664261.
+ if (IsAuraMusClient())
+ return;
+
// First, ensure the simulator is aware of the Widget created in SetUp() being
// currently active.
test::WidgetTest::SimulateNativeActivate(GetWidget());

Powered by Google App Engine
This is Rietveld 408576698