Changes views_aura_mus_unittests to create DesktopNativeWidgetAura

ui/views/test/native_widget_factory_desktop.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/test/native_widget_factory.h"
 
+#include "ui/views/test/test_platform_native_widget.h"
+
 #if defined(USE_AURA)
+#include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 #include "ui/views/widget/native_widget_aura.h"
-#if !defined(OS_CHROMEOS)
-#include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
-#endif
 #elif defined(OS_MACOSX)
 #include "ui/views/widget/native_widget_mac.h"
 #endif
 
 namespace views {
 namespace test {
 
-#if !defined(OS_CHROMEOS)
-
+NativeWidget* CreatePlatformNativeWidgetImpl(
+    const Widget::InitParams& init_params,
+    Widget* widget,
+    uint32_t type,
+    bool* destroyed) {
 #if defined(OS_MACOSX)
-using PlatformDesktopNativeWidget = NativeWidgetMac;
+  return new TestPlatformNativeWidget<NativeWidgetMac>(
+      widget, type == kStubCapture, destroyed);
 #else
-using PlatformDesktopNativeWidget = DesktopNativeWidgetAura;
+  return new TestPlatformNativeWidget<NativeWidgetAura>(
+      widget, type == kStubCapture, destroyed);
 #endif
-
-namespace {
-
-class TestPlatformDesktopNativeWidget : public PlatformDesktopNativeWidget {
- public:
-  TestPlatformDesktopNativeWidget(internal::NativeWidgetDelegate* delegate,
-                                  bool* destroyed);
-  ~TestPlatformDesktopNativeWidget() override;
-
- private:
-  bool* destroyed_;
-
-  DISALLOW_COPY_AND_ASSIGN(TestPlatformDesktopNativeWidget);
-};
-
-// A widget that assumes mouse capture always works. It won't in testing, so we
-// mock it.
-TestPlatformDesktopNativeWidget::TestPlatformDesktopNativeWidget(
-    internal::NativeWidgetDelegate* delegate,
-    bool* destroyed)
-    : PlatformDesktopNativeWidget(delegate), destroyed_(destroyed) {}
-
-TestPlatformDesktopNativeWidget::~TestPlatformDesktopNativeWidget() {
-  if (destroyed_)
-    *destroyed_ = true;
 }
 
-}  // namespace
-
-#endif
-
 NativeWidget* CreatePlatformDesktopNativeWidgetImpl(
     const Widget::InitParams& init_params,
     Widget* widget,
     bool* destroyed) {
-#if defined(OS_CHROMEOS)
-  // Chromeos only has one NativeWidgetType.
-  return CreatePlatformNativeWidgetImpl(init_params, widget, 0u, destroyed);
-#else
-  return new TestPlatformDesktopNativeWidget(widget, destroyed);
+#if defined(OS_MACOSX)
+  return new TestPlatformNativeWidget<NativeWidgetMac>(widget, false,
+                                                       destroyed);
+#elif defined(OS_CHROMEOS)
+  // Chromeos only has one NativeWidgetType. Chromeos with aura-mus does not
+  // compile this file.
+  return new TestPlatformNativeWidget<NativeWidgetAura>(widget, false,
+                                                        destroyed);
+#elif defined(USE_AURA)

[msw, 2016/11/11 00:29:24]

I guess this isn't compiled anywhere that lacks a return statement, still, maybe
add a NOTREACHED(); return nullptr; in an #else block or outside the
preprocessor macro blocks?

[sky, 2016/11/11 01:09:13]

Done.

+  return new TestPlatformNativeWidget<DesktopNativeWidgetAura>(widget, false,
+                                                               destroyed);
 #endif
 }
 
 }  // namespace test
 }  // namespace views