Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2488393002: Fix chromoting apt-config usage that breaks on Ubuntu 16.10. (Closed)

Created:
4 years, 1 month ago by Michael Moss
Modified:
4 years, 1 month ago
Reviewers:
Lambros, Tom Anderson
CC:
chromium-reviews, chromoting-reviews_chromium.org, Tom Anderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chromoting apt-config usage that breaks on Ubuntu 16.10. BUG=663069 R=lambroslambrou@chromium.org Committed: https://crrev.com/6e7cdc64930f4073c068b56eeae5625cc038756e Cr-Commit-Position: refs/heads/master@{#431409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M remoting/host/installer/linux/debian/postrm View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Michael Moss
4 years, 1 month ago (2016-11-10 20:54:00 UTC) #1
Lambros
lgtm, thanks for fixing our package.
4 years, 1 month ago (2016-11-10 21:05:23 UTC) #2
Lambros
On 2016/11/10 21:05:23, Lambros wrote: > lgtm, thanks for fixing our package. Do we need ...
4 years, 1 month ago (2016-11-10 21:13:21 UTC) #3
Michael Moss
On 2016/11/10 21:13:21, Lambros wrote: > On 2016/11/10 21:05:23, Lambros wrote: > > lgtm, thanks ...
4 years, 1 month ago (2016-11-10 21:18:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488393002/1
4 years, 1 month ago (2016-11-10 21:19:54 UTC) #6
Tom Anderson
lgtm, thanks mmoss! Are you also planning to change chrome/installer/linux/common/apt.include?
4 years, 1 month ago (2016-11-10 22:15:05 UTC) #8
Michael Moss
On 2016/11/10 22:15:05, Thomas Anderson wrote: > lgtm, thanks mmoss! > Are you also planning ...
4 years, 1 month ago (2016-11-10 22:25:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488393002/1
4 years, 1 month ago (2016-11-10 22:26:10 UTC) #12
Tom (Use chromium acct)
On 2016/11/10 22:25:18, Michael Moss wrote: > On 2016/11/10 22:15:05, Thomas Anderson wrote: > > ...
4 years, 1 month ago (2016-11-10 22:55:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:30:05 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:32:00 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e7cdc64930f4073c068b56eeae5625cc038756e
Cr-Commit-Position: refs/heads/master@{#431409}

Powered by Google App Engine
This is Rietveld 408576698