Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2488383003: Reenable several BrowserFocusTests under crbug/163931 (Closed)

Created:
4 years, 1 month ago by Qiang(Joe) Xu
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable several BrowserFocusTests under crbug/163931 Reenable the following tests in BrowserFocusTest for linux_aura: LocationBarLockFocus, FocusOnReload, FocusOnNavigate, By introducing BrowserActivationWaiter, this should guarantee no flaky on focus-related tests. BUG=163931 TEST=automate self tests Committed: https://crrev.com/0faadcf00b6bc5d9fb790be0bed2ecf9daeccf7c Cr-Commit-Position: refs/heads/master@{#431679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M chrome/browser/ui/browser_focus_uitest.cc View 3 chunks +10 lines, -27 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Qiang(Joe) Xu
Hi Scott, could you help review on this? Thanks!
4 years, 1 month ago (2016-11-11 22:16:44 UTC) #8
sky
Nice, LGTM
4 years, 1 month ago (2016-11-11 22:59:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488383003/1
4 years, 1 month ago (2016-11-11 23:05:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 23:13:46 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 23:54:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0faadcf00b6bc5d9fb790be0bed2ecf9daeccf7c
Cr-Commit-Position: refs/heads/master@{#431679}

Powered by Google App Engine
This is Rietveld 408576698