Implement aura::PropertyConverter for mus interop.

Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/28625ccf0b3bcbcf118f06024f78d975f7575d5b
Cr-Commit-Position: refs/heads/master@{#431743}

[msw, 2016-11-11 22:24:32]

Description was changed from

==========
Implement aura::PropertyConverter for mus interop.

BUG=663522
==========

to

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
==========

[msw, 2016-11-11 22:24:32]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-11-11 22:25:59]

Patchset #2 (id:20001) has been deleted

[msw, 2016-11-11 22:29:12]

Hey Scott, please take a look; thanks!
I'm happy to make heavy changes here; this is just one path forward.

[msw, 2016-11-11 22:29:17]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 22:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-11 22:59:15]

This is a good start. I have one question about using WindowProperty::key, but
LGTM

https://codereview.chromium.org/2488353005/diff/40001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2488353005/diff/40001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.cc:53: if (key == client::kAlwaysOnTopKey || key
== client::kAlwaysOnTopKey->name)
How do we end up using client::kAlwaysOnTopKey->name? By that I mean who passes
that property->key?

[msw, 2016-11-11 23:10:50]

https://codereview.chromium.org/2488353005/diff/40001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2488353005/diff/40001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.cc:53: if (key == client::kAlwaysOnTopKey || key
== client::kAlwaysOnTopKey->name)
On 2016/11/11 22:59:15, sky wrote:
> How do we end up using client::kAlwaysOnTopKey->name? By that I mean who
passes
> that property->key?

Removed. Good catch, this just supported an earlier version of the patch.

[msw, 2016-11-11 23:10:56]

The CQ bit was checked by msw@chromium.org

[msw, 2016-11-11 23:10:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2488353005/#ps60001
(title: "Remove key name comparison.")

[commit-bot: I haz the power, 2016-11-11 23:11:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:21:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-11-11 23:28:04]

Description was changed from

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
==========

to

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

[msw, 2016-11-11 23:28:04]

msw@chromium.org changed reviewers:
+ tsepez@chromium.org

[msw, 2016-11-11 23:30:24]

+TBR Tom for ui/aura/mus's new dependency on:
  services/ui/public/cpp/property_type_converters.h

[msw, 2016-11-11 23:39:38]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:40:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-12 00:56:49]

RS LGTM

[commit-bot: I haz the power, 2016-11-12 02:13:03]

Description was changed from

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

[commit-bot: I haz the power, 2016-11-12 02:13:04]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-12 02:16:16]

Description was changed from

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Implement aura::PropertyConverter for mus interop.

Provide an implementation for the interface.
TODO: Add other properties besides always-on-top.

Use aura::Window's internal int64_t property accessors.
TODO: This is wasteful for smaller types (eg. bool).

Use the existing property type converters.
TODO: Use Mojo's generated byte array Serialize function?

Some misc. TODO ideas to improve this or follow up:
TODO: Store aura::Window props by key *name*?
TODO: Store aura::Window props as std::vector<uint8_t>?
TODO: Optimize for smaller property types?
TODO: Let clients extend the set of known properties?
TODO: Nix WindowTreeClientDelegate::GetPropertyConverter?

BUG=663522
TEST=Automated
R=sky@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/28625ccf0b3bcbcf118f06024f78d975f7575d5b
Cr-Commit-Position: refs/heads/master@{#431743}
==========

[commit-bot: I haz the power, 2016-11-12 02:16:17]

Patchset 3 (id:??) landed as
https://crrev.com/28625ccf0b3bcbcf118f06024f78d975f7575d5b
Cr-Commit-Position: refs/heads/master@{#431743}