Remove Compiler access from ResolutionEnqueuer

Remove Compiler access from ResolutionEnqueuer

+ move CommonMasks into ClosedWorld
+ move OpenWorld into ResolutionWorldBuilder

Main changes in:
compiler.dart
enqueue.dart
world.dart
types/types.dart
universe/world_builder.dart

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/c6a7b1cc43eb30e4255fb1e1680d2015f8f9f05a

[Johnni Winther, 2016-11-11 14:26:55]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Johnni Winther, 2016-11-11 14:36:36]

Description was changed from

==========
Remove Compiler access from ResolutionEnqueuer

+ move CommonMasks into ClosedWorld
+ move OpenWorld into ResolutionWorldBuilder
==========

to

==========
Remove Compiler access from ResolutionEnqueuer

+ move CommonMasks into ClosedWorld
+ move OpenWorld into ResolutionWorldBuilder

Main changes in:
compiler.dart
enqueue.dart
world.dart
types/types.dart
universe/world_builder.dart
==========

[Harry Terkelsen, 2016-11-11 22:07:30]

lgtm

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common/resolution.dart (right):

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common/resolution.dart:161: /// Ensure the resolution all
members of [element].
resolution all -> resolution of all

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:157: Resolution resolution,
you can just do 'this.resolution' here since you don't use resolution in the
initializers

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/types/...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/types/...
pkg/compiler/lib/src/types/types.dart:146: if (typesInferrerInternal == null) {
typesInferrerInternal ??= ...

[Johnni Winther, 2016-11-14 09:11:56]

Patchset #2 (id:20001) has been deleted

[Johnni Winther, 2016-11-14 09:16:06]

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common/resolution.dart (right):

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common/resolution.dart:161: /// Ensure the resolution all
members of [element].
On 2016/11/11 22:07:30, Harry Terkelsen wrote:
> resolution all -> resolution of all

Done.

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:157: Resolution resolution,
On 2016/11/11 22:07:30, Harry Terkelsen wrote:
> you can just do 'this.resolution' here since you don't use resolution in the
> initializers

Done.

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/types/...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2488353004/diff/1/pkg/compiler/lib/src/types/...
pkg/compiler/lib/src/types/types.dart:146: if (typesInferrerInternal == null) {
On 2016/11/11 22:07:30, Harry Terkelsen wrote:
> typesInferrerInternal ??= ...

Done.

[Johnni Winther, 2016-11-14 09:42:36]

Description was changed from

==========
Remove Compiler access from ResolutionEnqueuer

+ move CommonMasks into ClosedWorld
+ move OpenWorld into ResolutionWorldBuilder

Main changes in:
compiler.dart
enqueue.dart
world.dart
types/types.dart
universe/world_builder.dart
==========

to

==========
Remove Compiler access from ResolutionEnqueuer

+ move CommonMasks into ClosedWorld
+ move OpenWorld into ResolutionWorldBuilder

Main changes in:
compiler.dart
enqueue.dart
world.dart
types/types.dart
universe/world_builder.dart

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c6a7b1cc43eb30e4255fb1e1680d2015f8f9f05a
==========

[Johnni Winther, 2016-11-14 09:42:38]

Committed patchset #2 (id:40001) manually as
c6a7b1cc43eb30e4255fb1e1680d2015f8f9f05a (presubmit successful).