Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2488353003: Revert of [android] Tweak data deps to include two chromium tool binaries. (Closed)

Created:
4 years, 1 month ago by Tobias Sargeant
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [android] Tweak data deps to include two chromium tool binaries. (patchset #2 id:20001 of https://codereview.chromium.org/2488013003/ ) Reason for revert: Causes dump_syms not to be built, official build bots failing. https://bugs.chromium.org/p/chromium/issues/detail?id=664423&q=dump_syms&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&desc=2 Original issue's description: > [android] Tweak data deps to include two chromium tool binaries. > > This includes: > - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously > only depended on the symlink, not the target thereof > - //build/android/pylib/device/commands -- we previously only had it set > as a dependency of the forwarder & incremental APKs > > This should prevent bots running chromium tests from downloading the devil > versions stored in GS. > > BUG=664211 > > Committed: https://crrev.com/459473d91b7a627024b3dbf016fa599b79c13845 > Cr-Commit-Position: refs/heads/master@{#431378} TBR=dpranke@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664211 Committed: https://crrev.com/1b8c4bd02e59932536f50f6d2b0d4fd4ed455ad7 Cr-Commit-Position: refs/heads/master@{#431552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M build/android/pylib/device/commands/BUILD.gn View 1 chunk +2 lines, -5 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +2 lines, -5 lines 0 comments Download
M build/symlink.gni View 2 chunks +1 line, -5 lines 0 comments Download
M tools/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Tobias Sargeant
Created Revert of [android] Tweak data deps to include two chromium tool binaries.
4 years, 1 month ago (2016-11-11 13:08:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488353003/1
4 years, 1 month ago (2016-11-11 13:08:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:09:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b8c4bd02e59932536f50f6d2b0d4fd4ed455ad7 Cr-Commit-Position: refs/heads/master@{#431552}
4 years, 1 month ago (2016-11-11 13:12:19 UTC) #7
Dirk Pranke
4 years, 1 month ago (2016-11-11 17:52:51 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698