Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2488343003:
Stop passing unsupported locale string to Android Webview (Closed)
|
Created:
4 years, 1 month ago by Yirui Huang Modified:
4 years, 1 month ago CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStop passing unsupported locale string to Android Webview
It turns out that AwContents.setLocale is not fully ready to accept
a comma separate locale string. Locale propagation is different
between Android Webview and Android Chrome Browser. This is a partial
revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64
since a comma separated locale string works fine on Chrome browser.
BUG=593515
Committed: https://crrev.com/ebbf8296f0b098a9f7aee2245d38170795821bbd
Cr-Commit-Position: refs/heads/master@{#431768}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Stop passing invalid locale string. It turned out that AwContents.setLocale is not ready to accept a comma separate locale string. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ========== to ========== Stop passing invalid locale string It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ==========
yirui@google.com changed reviewers: + ksk@google.com, nona@chromium.org, torne@chromium.org
Description was changed from ========== Stop passing invalid locale string It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ========== to ========== Stop passing unsupported locale string to Android Webview It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ==========
lgtm
The CQ bit was checked by yirui@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. If the path for handling locales is different between chrome and webview, can you add an actual integration test for this functionality in webview when you come to reland? (i.e. check that the right headers make it to a webserver, etc).
LGTM. If the path for handling locales is different between chrome and webview, can you add an actual integration test for this functionality in webview when you come to reland? (i.e. check that the right headers make it to a webserver, etc).
The CQ bit was checked by yirui@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Stop passing unsupported locale string to Android Webview It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ========== to ========== Stop passing unsupported locale string to Android Webview It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Stop passing unsupported locale string to Android Webview It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 ========== to ========== Stop passing unsupported locale string to Android Webview It turns out that AwContents.setLocale is not fully ready to accept a comma separate locale string. Locale propagation is different between Android Webview and Android Chrome Browser. This is a partial revert of https://crrev.com/9112d68d3d59f500ecd45e128337576aedaf5e64 since a comma separated locale string works fine on Chrome browser. BUG=593515 Committed: https://crrev.com/ebbf8296f0b098a9f7aee2245d38170795821bbd Cr-Commit-Position: refs/heads/master@{#431768} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ebbf8296f0b098a9f7aee2245d38170795821bbd Cr-Commit-Position: refs/heads/master@{#431768} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
