third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2488343002: Move clearPaintInvalidatinFlags after subtree walk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2488343002: Move clearPaintInvalidatinFlags after subtree walk (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index a707e836c4c8019810e10edde6ed38fad323ede4..730d8b7fd963e56e5794772a04ed92b0499dbb1d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -503,7 +503,6 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(

LayoutPoint previousLocation = paintInvalidator.previousLocationInBacking();

PaintInvalidationReason reason =

invalidatePaintIfNeeded(newPaintInvalidationState);

- clearPaintInvalidationFlags();

if (previousLocation != paintInvalidator.previousLocationInBacking()) {

newPaintInvalidationState

@@ -535,6 +534,8 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(

newPaintInvalidationState.updateForChildren(reason);

invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);

+ clearPaintInvalidationFlags();

}

void LayoutBoxModelObject::addOutlineRectsForNormalChildren(