Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2975)

Unified Diff: chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

Issue 24883002: Uses and returns the fractional width in text eliding (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More fixes per feedback Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc b/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
index 98325f594dc4428520245cfb6b9150e801006fb6..026b9d5de3f32455332502c5ee0fd0f017ee9988 100644
--- a/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
+++ b/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
@@ -20,6 +20,7 @@
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/pango_util.h"
#include "ui/gfx/rect.h"
+#include "ui/gfx/rect_conversions.h"
using WebKit::WebAutofillClient;
@@ -86,7 +87,8 @@ void AutofillPopupViewGtk::Show() {
}
void AutofillPopupViewGtk::InvalidateRow(size_t row) {
- GdkRectangle row_rect = controller_->GetRowBounds(row).ToGdkRectangle();
+ GdkRectangle row_rect =
+ gfx::ToEnclosingRect(controller_->GetRowBounds(row)).ToGdkRectangle();
GdkWindow* gdk_window = gtk_widget_get_window(window_);
gdk_window_invalidate_rect(gdk_window, &row_rect, FALSE);
}
@@ -100,7 +102,8 @@ void AutofillPopupViewGtk::UpdateBoundsAndRedrawPopup() {
controller_->popup_bounds().y());
GdkWindow* gdk_window = gtk_widget_get_window(window_);
- GdkRectangle popup_rect = controller_->popup_bounds().ToGdkRectangle();
+ GdkRectangle popup_rect =
+ gfx::ToEnclosingRect(controller_->popup_bounds()).ToGdkRectangle();
if (gdk_window != NULL)
gdk_window_invalidate_rect(gdk_window, &popup_rect, FALSE);
}
@@ -140,7 +143,7 @@ gboolean AutofillPopupViewGtk::HandleExpose(GtkWidget* widget,
gfx::Rect damage_rect(event->area);
for (size_t i = 0; i < controller_->names().size(); ++i) {
- gfx::Rect line_rect = controller_->GetRowBounds(i);
+ gfx::Rect line_rect = gfx::ToEnclosingRect(controller_->GetRowBounds(i));
// Only repaint and layout damaged lines.
if (!line_rect.Intersects(damage_rect))
continue;

Powered by Google App Engine
This is Rietveld 408576698