Uses and returns the fractional width in text eliding

ash/system/user/tray_user.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/user/tray_user.h"
 
 #include <algorithm>
 #include <climits>
 #include <vector>
 
@@ skipping 437 matching lines @@
 
 void PublicAccountUserDetails::Layout() {
   lines_.clear();
   const gfx::Rect contents_area = GetContentsBounds();
   if (contents_area.IsEmpty())
     return;
 
   // Word-wrap the label text.
   const gfx::Font font;
   std::vector<base::string16> lines;
-  gfx::ElideRectangleText(text_, font, contents_area.width(),
-                          contents_area.height(), gfx::ELIDE_LONG_WORDS,
+  gfx::ElideRectangleText(text_,
+                          font,
+                          static_cast<float>(contents_area.width()),

[msw, 2013/09/27 21:54:48]

Won't int->float implicit type conversion work here, and in similar cases?

[jianli, 2013/10/01 00:32:58]

Reverted. Changed INT_MAX to FLT_MAX in the following 2 places that call
ElideRectangleText to avoid the compiler from complaining.

+                          static_cast<float>(contents_area.height()),
+                          gfx::ELIDE_LONG_WORDS,
                           &lines);
   // Loop through the lines, creating a renderer for each.
   gfx::Point position = contents_area.origin();
   gfx::Range display_name(gfx::Range::InvalidRange());
   for (std::vector<base::string16>::const_iterator it = lines.begin();
        it != lines.end(); ++it) {
     gfx::RenderText* line = gfx::RenderText::CreateInstance();
     line->SetDirectionalityMode(gfx::DIRECTIONALITY_FROM_UI);
     line->SetText(*it);
     const gfx::Size size(contents_area.width(), line->GetStringSize().height());
@@ skipping 78 matching lines @@
   // Do a binary search for the minimum width that ensures no more than three
   // lines are needed. The lower bound is the minimum of the current bubble
   // width and the width of the link (as no wrapping is permitted inside the
   // link). The upper bound is the maximum of the largest allowed bubble width
   // and the sum of the label text and link widths when put on a single line.
   std::vector<base::string16> lines;
   while (min_width < max_width) {
     lines.clear();
     const int width = (min_width + max_width) / 2;
     const bool too_narrow = gfx::ElideRectangleText(
-        text_, font, width, INT_MAX, gfx::TRUNCATE_LONG_WORDS, &lines) != 0;
+        text_, font, static_cast<float>(width), static_cast<float>(INT_MAX),
+        gfx::TRUNCATE_LONG_WORDS, &lines) != 0;
     int line_count = lines.size();
     if (!too_narrow && line_count == 3 &&
             width - font.GetStringWidth(lines.back()) <=
             space_width + link_size.width()) {
       ++line_count;
     }
     if (too_narrow || line_count > 3)
       min_width = width + 1;
     else
       max_width = width;
   }
 
   // Calculate the corresponding height and set the preferred size.
   lines.clear();
   gfx::ElideRectangleText(
-      text_, font, min_width, INT_MAX, gfx::TRUNCATE_LONG_WORDS, &lines);
+      text_, font, static_cast<float>(min_width), static_cast<float>(INT_MAX),
+      gfx::TRUNCATE_LONG_WORDS, &lines);
   int line_count = lines.size();
   if (min_width - font.GetStringWidth(lines.back()) <=
       space_width + link_size.width()) {
     ++line_count;
   }
   const int line_height = font.GetHeight();
   const int link_extra_height = std::max(
       link_size.height() - learn_more_->GetInsets().top() - line_height, 0);
   preferred_size_ = gfx::Size(
       min_width + insets.width(),
@@ skipping 706 matching lines @@
       kUserIconLargeSize : kUserIconSize;
 
   avatar_->SetImage(
       ash::Shell::GetInstance()->session_state_delegate()->GetUserImage(
           multiprofile_index_),
       gfx::Size(icon_size, icon_size));
 }
 
 }  // namespace internal
 }  // namespace ash