Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2488293002: Disable UnblockedPopupShowsInHistoryAndOmnibox on Linux (Closed)

Created:
4 years, 1 month ago by vabr (Chromium)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable UnblockedPopupShowsInHistoryAndOmnibox on Linux PopupBlockerBrowserTest.UnblockedPopupShowsInHistoryAndOmnibox is flaky on Linux. This CL disables the test on Linux. TBR=bauerb@chromium.org, jochen@chromium.org BUG=663333 NOTRY=true Committed: https://crrev.com/1e377a797a25fc281e1fe818b1cb77576e2e8e46 Cr-Commit-Position: refs/heads/master@{#431267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
vabr (Chromium)
4 years, 1 month ago (2016-11-10 15:47:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488293002/1
4 years, 1 month ago (2016-11-10 15:48:11 UTC) #3
vabr (Chromium)
This compiles, so I'm going to add NOTRY=true to see it land before the end ...
4 years, 1 month ago (2016-11-10 16:01:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488293002/1
4 years, 1 month ago (2016-11-10 16:02:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 16:06:29 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 16:08:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e377a797a25fc281e1fe818b1cb77576e2e8e46
Cr-Commit-Position: refs/heads/master@{#431267}

Powered by Google App Engine
This is Rietveld 408576698