Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2488283003: bluetooth: web: Rename Blacklist to Blocklist (Closed)
Patch Set: Add deprecated histogram Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2cb2f83c1c90d7437ff3c42d3f8f012f08d056ba..d97ee96836d260348204fd18fe54d81dd12a7e3c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -4528,6 +4528,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Bluetooth.Web.Blacklist.ParsedNonEmptyString"
enum="BooleanSuccess">
+ <obsolete>
+ This histogram is deprecated in 2016 November.
Ilya Sherman 2016/11/22 22:26:26 nit: Please mention which histogram replaces it.
+ </obsolete>
<owner>jyasskin@chromium.org</owner>
<owner>ortuno@chromium.org</owner>
<owner>scheib@chromium.org</owner>
@@ -4540,6 +4543,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Bluetooth.Web.Blocklist.ParsedNonEmptyString"
+ enum="BooleanSuccess">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records the result of BluetoothBlocklist::Add parsing a non-empty string.
+ These strings will be updated dynamically by a server, and this histogram
+ provides feedback that parsing is functioning correctly on clients.
+
+ False values are BAD, a blocklist is failing to be applied correctly.
+ </summary>
+</histogram>
+
<histogram name="Bluetooth.Web.Characteristic.ReadValue.Outcome"
enum="WebBluetoothGATTOperationOutcome">
<owner>jyasskin@chromium.org</owner>
@@ -103712,7 +103729,7 @@ value.
<int value="10" label="Not Authorized"/>
<int value="11" label="Not Paired"/>
<int value="12" label="Not Supported"/>
- <int value="13" label="Blacklisted"/>
+ <int value="13" label="Blocklisted"/>
</enum>
<enum name="WebBluetoothGetCharacteristicOutcome" type="int">
@@ -103720,7 +103737,7 @@ value.
<int value="1" label="No device"/>
<int value="2" label="No service"/>
<int value="3" label="Not found"/>
- <int value="4" label="Blacklisted"/>
+ <int value="4" label="Blocklisted"/>
<int value="5" label="No characteristics"/>
</enum>
@@ -103746,7 +103763,7 @@ value.
<int value="10"
label="Chooser insta-closed because Chrome isn't allowed to ask for
permission to scan for BT devices"/>
- <int value="11" label="Blacklisted service UUID in filter"/>
+ <int value="11" label="Blocklisted service UUID in filter"/>
<int value="12" label="Bluetooth Overview Help link pressed."/>
<int value="13" label="Adapter Off Help link pressed."/>
<int value="14" label="Need Location Help link pressed."/>
« no previous file with comments | « third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom ('k') | tools/web_bluetooth/compact_blacklist.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698