Removing 16MB size limit for Mojo buffers.

mojo/edk/system/broker_host.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/broker_host.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "mojo/edk/embedder/named_platform_channel_pair.h"
 #include "mojo/edk/embedder/named_platform_handle.h"
 #include "mojo/edk/embedder/platform_handle_vector.h"
 #include "mojo/edk/embedder/platform_shared_buffer.h"
 #include "mojo/edk/system/broker_messages.h"
 
 namespace mojo {
 namespace edk {
 
-namespace {
-
-// To prevent abuse, limit the maximum size of shared memory buffers.
-// TODO(rockot): Re-consider this limit, or do something smarter.
-const uint32_t kMaxSharedBufferSize = 16 * 1024 * 1024;
-
-}  // namespace
-
 BrokerHost::BrokerHost(base::ProcessHandle client_process,
                        ScopedPlatformHandle platform_handle)
 #if defined(OS_WIN)
     : client_process_(client_process)
 #endif
 {
   CHECK(platform_handle.is_valid());
 
   base::MessageLoop::current()->AddDestructionObserver(this);
 
@@ skipping 60 matching lines @@
       BrokerMessageType::INIT, 0, sizeof(*name_data) * pipe_name.length(),
       &data, reinterpret_cast<void**>(&name_data));
   data->pipe_name_length = static_cast<uint32_t>(pipe_name.length());
   std::copy(pipe_name.begin(), pipe_name.end(), name_data);
   channel_->Write(std::move(message));
 }
 
 #endif  // defined(OS_WIN)
 
 void BrokerHost::OnBufferRequest(uint32_t num_bytes) {
-  scoped_refptr<PlatformSharedBuffer> buffer;
   scoped_refptr<PlatformSharedBuffer> read_only_buffer;
-  if (num_bytes <= kMaxSharedBufferSize) {
-    buffer = PlatformSharedBuffer::Create(num_bytes);
-    if (buffer)
-      read_only_buffer = buffer->CreateReadOnlyDuplicate();
-    if (!read_only_buffer)
-      buffer = nullptr;
-  } else {
-    LOG(ERROR) << "Shared buffer request too large: " << num_bytes;
-  }
+  scoped_refptr<PlatformSharedBuffer> buffer =
+      PlatformSharedBuffer::Create(num_bytes);
+  if (buffer)
+    read_only_buffer = buffer->CreateReadOnlyDuplicate();
+  if (!read_only_buffer)
+    buffer = nullptr;
 
   Channel::MessagePtr message = CreateBrokerMessage(
       BrokerMessageType::BUFFER_RESPONSE, buffer ? 2 : 0, nullptr);
   if (buffer) {
     ScopedPlatformHandleVectorPtr handles;
     handles.reset(new PlatformHandleVector(2));
     handles->at(0) = buffer->PassPlatformHandle().release();
     handles->at(1) = read_only_buffer->PassPlatformHandle().release();
     PrepareHandlesForClient(handles.get());
     message->SetHandles(std::move(handles));
@@ skipping 25 matching lines @@
       break;
   }
 }
 
 void BrokerHost::OnChannelError() { delete this; }
 
 void BrokerHost::WillDestroyCurrentMessageLoop() { delete this; }
 
 }  // namespace edk
 }  // namespace mojo