Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2488243003:
Reduce the list of idle_after_loading stories. (Closed)
DescriptionReduce the list of idle_after_loading stories.
The excessive CPU usage of the removed stories stems from ads that fail to load
deterministically under WPR. This makes them poor candidates to measure and fix
improvements for.
https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/
BUG=640398
Committed: https://crrev.com/bcd8adf62ab7756b980d91bde0d25ccea2ea0f4a
Cr-Commit-Position: refs/heads/master@{#432029}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + benjhayden@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
benjhayden@chromium.org changed reviewers: + nednguyen@google.com
I think Ned might be a better reviewer for this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Reduce the list of idle_after_loading stories. The excessive CPU usage of the removed stories stems from ads that fail to load deterministically under WPR. This makes them poor candidates to measure and fix improvements for. https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/ BUG=640398 ========== to ========== Reduce the list of idle_after_loading stories. The excessive CPU usage of the removed stories stems from ads that fail to load deterministically under WPR. This makes them poor candidates to measure and fix improvements for. https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/ BUG=640398 ==========
nednguyen@google.com changed reviewers: + charliea@chromium.org
On 2016/11/10 22:35:34, benjhayden wrote: > I think Ned might be a better reviewer for this? lgtm if Charlie is happy
lgtm
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reduce the list of idle_after_loading stories. The excessive CPU usage of the removed stories stems from ads that fail to load deterministically under WPR. This makes them poor candidates to measure and fix improvements for. https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/ BUG=640398 ========== to ========== Reduce the list of idle_after_loading stories. The excessive CPU usage of the removed stories stems from ads that fail to load deterministically under WPR. This makes them poor candidates to measure and fix improvements for. https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/ BUG=640398 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reduce the list of idle_after_loading stories. The excessive CPU usage of the removed stories stems from ads that fail to load deterministically under WPR. This makes them poor candidates to measure and fix improvements for. https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/ BUG=640398 ========== to ========== Reduce the list of idle_after_loading stories. The excessive CPU usage of the removed stories stems from ads that fail to load deterministically under WPR. This makes them poor candidates to measure and fix improvements for. https://docs.google.com/document/d/1YVO9FGRBF1RUsedU28H6P8lt9bDpOci0vi0CLSkFih8/ BUG=640398 Committed: https://crrev.com/bcd8adf62ab7756b980d91bde0d25ccea2ea0f4a Cr-Commit-Position: refs/heads/master@{#432029} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bcd8adf62ab7756b980d91bde0d25ccea2ea0f4a Cr-Commit-Position: refs/heads/master@{#432029} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
