Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2488223002: [runtime] Ensure Object.freeze() deoptimizes code that depends on global property cells. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Ensure Object.freeze() deoptimizes code that depends on global property cells. BUG=chromium:663750 Committed: https://crrev.com/6aa16edf36ae0f0fbfaf8eedccbcf1f5a7e801c1 Cr-Commit-Position: refs/heads/master@{#40882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M src/objects.cc View 4 chunks +33 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-663750.js View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-10 09:19:50 UTC) #5
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-10 10:32:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488223002/1
4 years, 1 month ago (2016-11-10 10:34:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 10:36:46 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aa16edf36ae0f0fbfaf8eedccbcf1f5a7e801c1
Cr-Commit-Position: refs/heads/master@{#40882}

Powered by Google App Engine
This is Rietveld 408576698