[Extensions] Don't remove the bookmark drag event router as delegate

[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
BUG=664419
Committed: https://crrev.com/62fa72cbd02ff4e279efe12145dd4b1a3d221821
Cr-Commit-Position: refs/heads/master@{#431607}

[Devlin, 2016-11-11 02:29:26]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 02:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 03:08:48]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-11-11 03:09:25]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-11-11 03:09:25]

Antony, mind taking a look?

[Devlin, 2016-11-11 15:29:05]

Description was changed from

==========
[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
==========

to

==========
[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
BUG=664419
==========

[asargent_no_longer_on_chrome, 2016-11-11 17:39:08]

lgtm

[Devlin, 2016-11-11 18:58:29]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-11-11 18:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:04:11]

Description was changed from

==========
[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
BUG=664419
==========

to

==========
[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
BUG=664419
==========

[commit-bot: I haz the power, 2016-11-11 19:04:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 19:30:25]

Description was changed from

==========
[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
BUG=664419
==========

to

==========
[Extensions] Don't remove the bookmark drag event router as delegate

Previously, the BookmarkManagerPrivateDragEventRouter removed itself as
the BookmarkTabHelper's delegate on destruction.  Since
crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router
and the BookmarkTabHelper are WebContentsUserData, and thus will be
destroyed at the "same" time (that is, synchronously - if the
BookmarkTabHelper tried to access the
BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but
hopefully we never do that). Don't remove the
BookmarkManagerPrivateDragEventRouter as a delegate since there's a
chance the BookmarkTabHelper has already been destroyed.

BUG=664371
BUG=664419

Committed: https://crrev.com/62fa72cbd02ff4e279efe12145dd4b1a3d221821
Cr-Commit-Position: refs/heads/master@{#431607}
==========

[commit-bot: I haz the power, 2016-11-11 19:30:26]

Patchset 1 (id:??) landed as
https://crrev.com/62fa72cbd02ff4e279efe12145dd4b1a3d221821
Cr-Commit-Position: refs/heads/master@{#431607}