Generate inferred names for es6 class functions

Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/e80cfa000b5be9ee92b9fd95ebe63cb2da63c553
Cr-Commit-Position: refs/heads/master@{#41013}

[luoe, 2016-11-11 02:07:21]

Description was changed from

==========
Generate inferred names for es6 class functions

BUG=5621
==========

to

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=5621
==========

[luoe, 2016-11-11 02:08:17]

luoe@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[luoe, 2016-11-11 02:08:17]

@kozyatinskiy, do you know who would be the best reviewers / owners I should CC?

[luoe, 2016-11-11 03:31:54]

luoe@chromium.org changed reviewers:
+ einbinder@chromium.org

[kozy, 2016-11-11 05:40:25]

kozyatinskiy@chromium.org changed reviewers:
+ yangguo@chromium.org

[kozy, 2016-11-11 05:40:25]

wow, great.
lgtm,

Yang, could you take a look?

[kozy, 2016-11-11 05:43:11]

Please add following line into CL description.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
to force running blink layout tests to check that all layout tests are ready for
this change. Or check it manually.

[Yang, 2016-11-11 05:48:01]

yangguo@chromium.org changed reviewers:
+ vogelheim@chromium.org

[Yang, 2016-11-11 05:48:02]

lgtm, but some actual owner needs to review this.

[einbinder, 2016-11-11 08:51:42]

https://codereview.chromium.org/2488193003/diff/1/test/inspector/runtime/func...
File test/inspector/runtime/function-inferred-names-expected.txt (right):

https://codereview.chromium.org/2488193003/diff/1/test/inspector/runtime/func...
test/inspector/runtime/function-inferred-names-expected.txt:1: a
What is going on in this expected file?

[luoe, 2016-11-11 18:30:45]

Expectation set, test description added.  PTAL

https://codereview.chromium.org/2488193003/diff/1/test/inspector/runtime/func...
File test/inspector/runtime/function-inferred-names-expected.txt (right):

https://codereview.chromium.org/2488193003/diff/1/test/inspector/runtime/func...
test/inspector/runtime/function-inferred-names-expected.txt:1: a
On 2016/11/11 08:51:41, einbinder wrote:
> What is going on in this expected file?

Good catch, I forgot to set the expectation.txt file, sorry.

[luoe, 2016-11-11 19:04:40]

Description was changed from

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=5621
==========

to

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
==========

[luoe, 2016-11-14 18:54:48]

luoe@chromium.org changed reviewers:
+ marja@chromium.org

[luoe, 2016-11-14 18:54:48]

@marja, if you're working on V8 parser-related things, would you like to take a
look?

[vogelheim, 2016-11-14 19:27:14]

lgtm

[luoe, 2016-11-14 19:28:59]

Description was changed from

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
==========

to

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[luoe, 2016-11-14 19:29:07]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 19:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-11-14 19:40:07]

https://codereview.chromium.org/2488193003/diff/20001/test/inspector/runtime/...
File test/inspector/runtime/function-inferred-names.js (right):

https://codereview.chromium.org/2488193003/diff/20001/test/inspector/runtime/...
test/inspector/runtime/function-inferred-names.js:11: 
What's up with this duplication? What are these strings used for? (I'm not
familiar with these kind of tests.)

[luoe, 2016-11-14 19:51:38]

https://codereview.chromium.org/2488193003/diff/20001/test/inspector/runtime/...
File test/inspector/runtime/function-inferred-names.js (right):

https://codereview.chromium.org/2488193003/diff/20001/test/inspector/runtime/...
test/inspector/runtime/function-inferred-names.js:11: 
My fault here, I thought I removed these duplicate strings.  They aren't being
used at all.

This new test file is a part of the group that checks interactions between V8
and the inspector protocol.

[luoe, 2016-11-14 19:51:43]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 19:51:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 20:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:53:58]

Dry run: This issue passed the CQ dry run.

[marja, 2016-11-15 14:32:38]

lgtm, but the test is kinda indirect... it should be possible to test this with
a normal mjsunit test without going through the inspector!

[Yang, 2016-11-15 14:34:31]

On 2016/11/15 14:32:38, marja wrote:
> lgtm, but the test is kinda indirect... it should be possible to test this
with
> a normal mjsunit test without going through the inspector!

yes. iirc stack traces also use inferred names.

[marja, 2016-11-15 16:03:59]

On 2016/11/15 14:34:31, Yang wrote:
> On 2016/11/15 14:32:38, marja wrote:
> > lgtm, but the test is kinda indirect... it should be possible to test this
> with
> > a normal mjsunit test without going through the inspector!
> 
> yes. iirc stack traces also use inferred names.

Based on the CL description, even simpler tests (without stack traces) should be
possible.

[Yang, 2016-11-15 16:37:10]

On 2016/11/15 16:03:59, marja wrote:
> On 2016/11/15 14:34:31, Yang wrote:
> > On 2016/11/15 14:32:38, marja wrote:
> > > lgtm, but the test is kinda indirect... it should be possible to test this
> > with
> > > a normal mjsunit test without going through the inspector!
> > 
> > yes. iirc stack traces also use inferred names.
> 
> Based on the CL description, even simpler tests (without stack traces) should
be
> possible.

we also have a cctest/test-func-name-inferrer for this

[luoe, 2016-11-15 19:28:44]

Ah, I didn't know there were already tests for name inference in cctest.  I've
removed the inspector protocol ones and added a case in the existing file for
the object property scenario.

Thanks for the help reviewing!

[luoe, 2016-11-15 19:28:50]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 19:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 19:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:34:41]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28606)

[luoe, 2016-11-15 19:36:54]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 19:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-11-15 19:45:58]

lbtm (looks better to me) (ie lgtm)

[commit-bot: I haz the power, 2016-11-15 20:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:55:29]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-11-15 21:54:19]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-11-15 21:54:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, yangguo@chromium.org, vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2488193003/#ps90001
(title: "git cl format")

[commit-bot: I haz the power, 2016-11-15 21:54:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:57:43]

Description was changed from

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-11-15 21:57:44]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-11-17 22:35:13]

Description was changed from

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Generate inferred names for es6 class functions

Inferred names are currently generated for FunctionLiterals but not generated
for ClassLiterals. Without them, DevTools does not have enough information to
make descriptive descriptions.

E.g.
var x = {y: class{}};
var a = new x.y();
console.log(a);

This shows "Object{}" when it could be more descriptive "x.y {}"

BUG=v8:5621
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/e80cfa000b5be9ee92b9fd95ebe63cb2da63c553
Cr-Commit-Position: refs/heads/master@{#41013}
==========

[commit-bot: I haz the power, 2016-11-17 22:35:14]

Patchset 6 (id:??) landed as
https://crrev.com/e80cfa000b5be9ee92b9fd95ebe63cb2da63c553
Cr-Commit-Position: refs/heads/master@{#41013}