Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2488183002: [turbofan] Address a couple of Type-related TODOs. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Address a couple of Type-related TODOs. This cleans up a few Type related TODOs, i.e. removing the now useless kSmi and kHeapNumber members from TypeCache. R=yangguo@chromium.org BUG=v8:5267 Committed: https://crrev.com/fa9e404bf0552d0ee1b38b23e5280e44c3d25dd0 Cr-Commit-Position: refs/heads/master@{#40874}

Patch Set 1 #

Patch Set 2 : Now with green bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M src/compiler/access-builder.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/access-info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/type-cache.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-10 06:17:14 UTC) #1
Benedikt Meurer
Hey Yang, Here's a set of simple cleanups for type related TODOs in TurboFan. Please ...
4 years, 1 month ago (2016-11-10 06:18:03 UTC) #4
Yang
On 2016/11/10 06:18:03, Benedikt Meurer wrote: > Hey Yang, > > Here's a set of ...
4 years, 1 month ago (2016-11-10 06:34:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488183002/20001
4 years, 1 month ago (2016-11-10 06:39:27 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 06:53:09 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa9e404bf0552d0ee1b38b23e5280e44c3d25dd0
Cr-Commit-Position: refs/heads/master@{#40874}

Powered by Google App Engine
This is Rietveld 408576698