Issue 2488163004: Ensure that navigation will proceed when no NavigationHandle is found

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2488163004: Ensure that navigation will proceed when no NavigationHandle is found (Closed)

Created:
4 years, 1 month ago by clamy

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Ensure that navigation will proceed when no NavigationHandle is found This is a fix for an issue where the NavigationHandle is destroyed by the commit of a same-page navigation, which will cancel an ongoing navigation. This patch allows the navigation to go through, and is meant to be a temporary fix until https://codereview.chromium.org/2475693002/ lands. BUG=658530 Review-Url: https://codereview.chromium.org/2481173002 Cr-Commit-Position: refs/heads/master@{#430650} (cherry picked from commit 13dbcd1e7b46a500c1afde8256949aeecdcb18be) Committed: https://chromium.googlesource.com/chromium/src/+/34708c0c752eaf5bfa865c2233f4272cc5d3e208

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/loader/navigation_resource_throttle.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

clamy

4 years, 1 month ago (2016-11-10 11:03:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
34708c0c752eaf5bfa865c2233f4272cc5d3e208.