Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2488163002: Include paint of background (tiled) image in FCP (Closed)

Created:
4 years, 1 month ago by panicker
Modified:
4 years, 1 month ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include paint of background (tiled) image in FCP BUG=663972 Committed: https://crrev.com/8e8f1fd1f959af69b0f19f353bbc57f22956912f Cr-Commit-Position: refs/heads/master@{#431497}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add another setImagePainted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
panicker
As discussed: add setImagePainted in drawTiledImaged.
4 years, 1 month ago (2016-11-10 01:28:19 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/2488163002/diff/1/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right): https://codereview.chromium.org/2488163002/diff/1/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp#newcode922 third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:922: image->drawTiled(*this, dest, srcRect, tileScaleFactor, hRule, vRule, op); Call setImagePainted() ...
4 years, 1 month ago (2016-11-10 01:45:30 UTC) #3
panicker
https://codereview.chromium.org/2488163002/diff/1/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right): https://codereview.chromium.org/2488163002/diff/1/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp#newcode922 third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:922: image->drawTiled(*this, dest, srcRect, tileScaleFactor, hRule, vRule, op); On 2016/11/10 ...
4 years, 1 month ago (2016-11-10 01:59:43 UTC) #4
Kunihiko Sakamoto
lgtm Thank you for doing this!
4 years, 1 month ago (2016-11-10 02:00:35 UTC) #5
chrishtr
lgtm
4 years, 1 month ago (2016-11-11 01:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488163002/20001
4 years, 1 month ago (2016-11-11 01:16:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 04:29:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 05:16:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e8f1fd1f959af69b0f19f353bbc57f22956912f
Cr-Commit-Position: refs/heads/master@{#431497}

Powered by Google App Engine
This is Rietveld 408576698