Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2488153003: Create chrome://offline URL (Closed)

Created:
4 years, 1 month ago by Olivier
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create chrome://offline URL This URL will be used to load distilled pages in Chrome. BUG=664124 Committed: https://crrev.com/9079aef006b0740dd5d0d2cd8b3ad06ad733a20e Cr-Commit-Position: refs/heads/master@{#432432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ios/chrome/browser/chrome_url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/chrome_url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Olivier
4 years, 1 month ago (2016-11-10 15:46:03 UTC) #2
jif-google
lgtm
4 years, 1 month ago (2016-11-10 15:50:28 UTC) #4
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-10 15:59:39 UTC) #5
jif
lgtm
4 years, 1 month ago (2016-11-10 16:02:14 UTC) #6
Olivier
+sdefresne for owner.
4 years, 1 month ago (2016-11-10 16:06:47 UTC) #8
Olivier
ping for sdefresne.
4 years, 1 month ago (2016-11-16 08:23:21 UTC) #9
sdefresne
lgtm
4 years, 1 month ago (2016-11-16 08:28:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488153003/1
4 years, 1 month ago (2016-11-16 08:29:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 08:37:39 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 08:41:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9079aef006b0740dd5d0d2cd8b3ad06ad733a20e
Cr-Commit-Position: refs/heads/master@{#432432}

Powered by Google App Engine
This is Rietveld 408576698