Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2488143002:
Roll DEPS for clang to 63ca7c81. (Closed)
|
Created:
4 years, 1 month ago by Lei Zhang Modified:
4 years, 1 month ago Reviewers:
Dirk Pranke CC:
pdfium-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
pdfium Visibility:
Public. |
DescriptionRoll DEPS for clang to 63ca7c81.
Also roll DEPS for build/ to 98f2d80a which is required, and update the
build_overrides for the new build configs.
Also bump the android_ndk_revision version to 26d93ec07.
BUG=chromium:663913
TBR=dpranke@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/50feafc7f367a87b7e4e689421eb7ae1484660d9
Patch Set 1 #Patch Set 2 : fix android #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)
jbudorick: Do you happen to have the quick answer for how to fix the Android bots?
On 2016/11/10 01:26:10, Lei Zhang (slow) wrote: > jbudorick: Do you happen to have the quick answer for how to fix the Android > bots? I do (and I have a local patch that does it): we roll the ndk to r12b -- specifically, https://chromium.googlesource.com/android_ndk/+/26d93ec07f3ce2ec2cdfeae1b21ee..., which is what chromium is on as of today.
On 2016/11/10 01:39:50, jbudorick wrote: > On 2016/11/10 01:26:10, Lei Zhang (slow) wrote: > > jbudorick: Do you happen to have the quick answer for how to fix the Android > > bots? > > I do (and I have a local patch that does it): we roll the ndk to r12b -- > specifically, > https://chromium.googlesource.com/android_ndk/+/26d93ec07f3ce2ec2cdfeae1b21ee..., > which is what chromium is on as of today. (there are other, less quick fixes we could do, too, if we want to keep pdfium on r11c, but I don't know of a reason to do so.)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/10 01:39:50, jbudorick wrote: > On 2016/11/10 01:26:10, Lei Zhang (slow) wrote: > > jbudorick: Do you happen to have the quick answer for how to fix the Android > > bots? > > I do (and I have a local patch that does it): we roll the ndk to r12b -- > specifically, > https://chromium.googlesource.com/android_ndk/+/26d93ec07f3ce2ec2cdfeae1b21ee..., > which is what chromium is on as of today. Thank you. Exactly what I needed!
Description was changed from ========== Roll DEPS for clang to 63ca7c81. Also roll DEPS for build/ to 98f2d80a which is required, and update the build_overrides for the new build configs. BUG=chromium:663913 ========== to ========== Roll DEPS for clang to 63ca7c81. Also roll DEPS for build/ to 98f2d80a which is required, and update the build_overrides for the new build configs. Also bump the android_ndk_revision version to 26d93ec07. BUG=chromium:663913 ==========
thestig@chromium.org changed reviewers: + dpranke@chromium.org
Description was changed from ========== Roll DEPS for clang to 63ca7c81. Also roll DEPS for build/ to 98f2d80a which is required, and update the build_overrides for the new build configs. Also bump the android_ndk_revision version to 26d93ec07. BUG=chromium:663913 ========== to ========== Roll DEPS for clang to 63ca7c81. Also roll DEPS for build/ to 98f2d80a which is required, and update the build_overrides for the new build configs. Also bump the android_ndk_revision version to 26d93ec07. BUG=chromium:663913 TBR=dpranke@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
TBR
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll DEPS for clang to 63ca7c81. Also roll DEPS for build/ to 98f2d80a which is required, and update the build_overrides for the new build configs. Also bump the android_ndk_revision version to 26d93ec07. BUG=chromium:663913 TBR=dpranke@chromium.org ========== to ========== Roll DEPS for clang to 63ca7c81. Also roll DEPS for build/ to 98f2d80a which is required, and update the build_overrides for the new build configs. Also bump the android_ndk_revision version to 26d93ec07. BUG=chromium:663913 TBR=dpranke@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/50feafc7f367a87b7e4e689421eb7ae14846... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/50feafc7f367a87b7e4e689421eb7ae14846...
Message was sent while issue was closed.
lgtm |
