Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2488123002: Move remote_channel_main logging flag into launch script and add blimp module verbose logging (Closed)

Created:
4 years, 1 month ago by steimel
Modified:
4 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remote_channel_main logging flag into launch script and add blimp module verbose logging BUG=663951 Committed: https://crrev.com/dcfdf7d70ba770ea2f7242a029d8a2d361533569 Cr-Commit-Position: refs/heads/master@{#431146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M blimp/engine/app/blimp_content_main_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M blimp/engine/start_engine.sh View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
steimel
PTAL
4 years, 1 month ago (2016-11-10 00:36:41 UTC) #2
Wez
lgtm
4 years, 1 month ago (2016-11-10 02:16:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488123002/1
4 years, 1 month ago (2016-11-10 02:17:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 02:30:43 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 02:41:58 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dcfdf7d70ba770ea2f7242a029d8a2d361533569
Cr-Commit-Position: refs/heads/master@{#431146}

Powered by Google App Engine
This is Rietveld 408576698