appengine/findit/predator/README.md - Issue 2488113005: [Findit] Re-org code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/predator/README.md

Issue 2488113005: [Findit] Re-org code. (Closed)

Patch Set: Address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Code structure

	2

	3 * [analysis](analysis): Core library for analyzing Chrome crashes.

	4 * [app](app): The App Engine app to provide web APIs to analyze Chrome crashes t hrough invoking the core library above, and web pages to view & monitor analysis results.
	wrengr 2016/11/15 00:38:01 nit: line too long nit: line too long stgao 2016/11/16 18:44:11 This is OK for text file, but not for code file. Show quoted text On 2016/11/15 00:38:01, wrengr wrote: > nit: line too long This is OK for text file, but not for code file.
	5

	6 # Refactoring guideline

	7 * All core logic of analysis should live in [analysis](analysis), and it should

	8 be standalone, and not depend any App Engine APIs.

	9 * All app-layer code should live in [app](app)

	10 * Frontend code rendering UIs to providing APIs for clients like ClusterFuzz/F racas/Cracas should live in [app/frontend](app/frontend).

	11 * Backend code running the analysis should live in [app/backend](app/backend).

	12 * Shared code between the frontend and backend should live in [app/common](app /common).

	13

	14 # Next step

	15 When the refactoring is done, we will do a one-off move to appengine/predator.

OLD	NEW